Added submissions archives. #1656
Open
+733
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gogo4ds
requested changes
Jun 26, 2025
Comment on lines
+13
to
+35
| public static Expression<Func<Submission, ArchivedSubmission>> FromSubmission => | ||
| submission => new ArchivedSubmission | ||
| { | ||
| Id = submission.Id, | ||
| ParticipantId = submission.ParticipantId, | ||
| ProblemId = submission.ProblemId, | ||
| SubmissionTypeId = submission.SubmissionTypeId, | ||
| Content = submission.Content, | ||
| FileExtension = submission.FileExtension, | ||
| SolutionSkeleton = submission.SolutionSkeleton, | ||
| StartedExecutionOn = submission.StartedExecutionOn, | ||
| CompletedExecutionOn = submission.CompletedExecutionOn, | ||
| IpAddress = submission.IpAddress, | ||
| WorkerName = submission.WorkerName, | ||
| ExceptionType = submission.ExceptionType, | ||
| Processed = submission.Processed, | ||
| Points = submission.Points, | ||
| ProcessingComment = submission.ProcessingComment, | ||
| TestRunsCache = submission.TestRunsCache, | ||
| CreatedOn = submission.CreatedOn, | ||
| ModifiedOn = submission.ModifiedOn, | ||
| IsHardDeletedFromMainDatabase = false, | ||
| }; |
There was a problem hiding this comment.
Make sure it has all the properties.. legacy and alpha might have slight differences already.
| @@ -34,6 +34,7 @@ public static void Main(string[] args) | |||
| .AddTransient(typeof(IDataService<>), typeof(DataService<>)) | |||
| .AddTransient<ITransactionsProvider, TransactionsProvider<OjsDbContext>>() | |||
| .AddIdentityDatabase<OjsDbContext, UserProfile, Role, UserInRole>(configuration) | |||
| .AddArchivesDatabase(configuration) | |||
There was a problem hiding this comment.
For now we don't need this db in ui
|
|
||
| public async Task<int> ArchiveOldSubmissionsDailyBatch(int limit, int maxSubBatchSize) | ||
| { | ||
| await this.archivesData.CreateDatabaseIfNotExists(); |
There was a problem hiding this comment.
Why not use MigrateDatabase in Program.cs like for the OjsDbContext.
Comment on lines
+132
to
+142
| var submissionBatches = deleteCountLimit > 0 | ||
| ? this.archivesDataService | ||
| .GetAllNotHardDeletedFromMainDatabase() | ||
| .Distinct() | ||
| .OrderBy(x => x.Id) | ||
| .InSelfModifyingBatches(GlobalConstants.BatchOperationsChunkSize, deleteCountLimit) | ||
| : this.archivesDataService | ||
| .GetAllNotHardDeletedFromMainDatabase() | ||
| .Distinct() | ||
| .OrderBy(x => x.Id) | ||
| .InSelfModifyingBatches(GlobalConstants.BatchOperationsChunkSize); |
| @@ -40,12 +40,14 @@ public static void ConfigureServices( | |||
| .AddHttpClients(configuration) | |||
| .AddTransient(typeof(IDataService<>), typeof(AdministrationDataService<>)) | |||
| .AddTransient<ITransactionsProvider, TransactionsProvider<OjsDbContext>>() | |||
| .AddTransient<IArchivesDataService, ArchivesDataService>() | |||
There was a problem hiding this comment.
Why isn't this autoregistered?
Comment on lines
+25
to
+26
| private readonly string archiveOldSubmissionsWithLimitCronExpression = Cron.Yearly(1, 1, 2, 30); | ||
| private readonly string hardDeleteArchivedSubmissionsCronExpression = Cron.Yearly(1, 1, 2, 30); |
There was a problem hiding this comment.
Why are these jobs added? We don't need a job that executes once a year..
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes https://github.com/SoftUni-Internal/exam-systems-issues/issues/1726