Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pa calib: print flow value and acceleration #7178

Merged
merged 3 commits into from
Oct 24, 2024

Conversation

buzzhuzz
Copy link
Contributor

Print flow value and acceleration for PA pattern calibration. This should help keep track during adaptive PA calibration.

Description

Modify Pattern PA calibration to print current Flow Rate and Acceleration values which should help following Adaptive PA calibration guidelines.

Those values printed below PA values:

  • last line is Acceleration
  • second to last line is Flow Rate

Screenshots/Recordings/Graphs

Screenshot from 2024-10-21 17-09-01

Tests

Manual tests with several speed ratios: checked printed flow rate matches one reported by gcode preview.

Print flow value and acceleration for PA pattern calibration.
This should help keep track during adaptive PA calibration.
@igiannakas
Copy link
Contributor

NICE! thank you for this, that's fantastic!

@kylek29
Copy link

kylek29 commented Oct 22, 2024

I do like this, especially for those of us with Bambu printers because they don't give us any of this information.

@SoftFever
Copy link
Owner

Hi @buzzhuzz
Nice one, this is very handy 👍
I have two pieces of feedback:

  1. Could we round the flow rate value to one decimal place?
  2. With the number rounded as suggested in 1, could we make the box thinner?
Screenshot 2024-10-24 at 12 10 52 AM

Rework pa pattern legent generation to correctly estimate
width of the legend section.

Current flow value now has variable length which is a longest of
PA value and the acceleration for a given test.

Few examples:
1. PA value are 4 characters:        0.04
   Acceleratioion 3 chars:           400
   Flow value will be 4 chars long:  7.98, or 11.3

2. PA:      0.018
   Accel:   1000
   Flow:    12.35, or 6.345

3. PA:      0.04
   Accel:   15000
   Flow:    34.34, or 4.567

Rework number-to-string conversion flow to correctly round values at
given precision.
@buzzhuzz
Copy link
Contributor Author

@SoftFever, thanks for your feedback.

I have found a bug in previous implementation which causes legend section to be too-wide in some cases.
Additionally, flow value precision now trimmed to not exceed length of PA value and acceleration strings.

For example:
Screenshot from 2024-10-24 11-58-14

Screenshot from 2024-10-24 11-59-02
Screenshot from 2024-10-24 11-59-55

@SoftFever
Copy link
Owner

@SoftFever, thanks for your feedback.

I have found a bug in previous implementation which causes legend section to be too-wide in some cases. Additionally, flow value precision now trimmed to not exceed length of PA value and acceleration strings.

Perfect!
Thanks :)

@SoftFever SoftFever merged commit 983f1a8 into SoftFever:main Oct 24, 2024
15 checks passed
@buzzhuzz buzzhuzz deleted the dbuzz/pa-pattern-print-flow-accel branch October 24, 2024 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants