Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update OrcaSlicer_es.po #6381

Merged
merged 20 commits into from
Sep 3, 2024
Merged

Update OrcaSlicer_es.po #6381

merged 20 commits into from
Sep 3, 2024

Conversation

gatosardina
Copy link
Contributor

This pull request is not ready to merge.

I need confirmation on character limit per line.

This was a quick overview of the changes in the previous spanish translation update, plus some quick changes in related strings

@gatosardina
Copy link
Contributor Author

msgid "Object coordinates"

Is this the object coordinates expressed in the world coordinates, or the coordinates of "something" expressed in the object's coordinates?

msgid "Frustum"

What is that? Where is it used (in orcaslicer? frustrum is a portion of a pyramid or cone, without the 'tip'

msgid "Set Mirror"
Where is this used?

msgid "Click to change text into object part."
Where is this used?

msgid "First Add style to list."
Where is this used?

msgid "Undefined stroke type"
Where is this used?

msgid "Open filled path"
Where is this used?

msgid "Select settings"
Where is this used?

msgid "Delete connector from object which is a part of cut"
Where is this used?

@gatosardina gatosardina marked this pull request as draft August 8, 2024 12:30
@hliebscher
Copy link
Contributor

Where is this used?

All msgids are inserted and used by a script; you can search for them in the code afterwards.

The term “Frustum” refers to a geometric shape that is typically used in 3D graphics and computer vision. It is formed by slicing the top off a cone or pyramid, creating a shape that has two parallel faces: a smaller top and a larger base. In 3D graphics, the view frustum is particularly important, as it represents the field of view of a camera. Objects within this frustum are visible in the rendered scene, while those outside are clipped and not displayed. The shape is crucial in determining what parts of a scene should be rendered on the screen.

pls translate all msgid's

@gatosardina
Copy link
Contributor Author

gatosardina commented Aug 9, 2024

I know what a frustrum is, i'm asking where is it used because the current translation does not seem to fit its meaning

I am reviweing and correcting all msgid in the already existing spanish localization

I can imagine that msgids are placed by a script, I'm asking where contextually in the app some msgstr are used to know what exactly is the meaning behind the message. As in, what can i do in the app to get certain message

I will commit new changes to this pull request branch as I cmmit them to my fork

@gatosardina
Copy link
Contributor Author

I've reviewed around half of the file, up to line 10024
I would like confirmation on my previous comment plus some comments i've left in the code (you can find them starting with
#. ? )

@gatosardina
Copy link
Contributor Author

Aight, I think it's done.

Sorry for the delay, I was on vacation.

I assumme all lines starting with #~ are commented out?

I reckon they are a lot of changes to review one by one.
If anything, I would like for my comments (starting with "#. ?') are reviewed, but otherwise it's ready.

@gatosardina gatosardina marked this pull request as ready for review August 26, 2024 11:44
@gatosardina
Copy link
Contributor Author

gatosardina commented Aug 27, 2024

Aight I resolved the conflicts arising from pull request #6543

I also updated a few translations based on the changes of that commit.

I do have a question though, that pull request removed the following msgids.
Was it intentional?
I removed them from my fork as well

<<<<<<< patch-1
msgid ""
"Time for the printer firmware (or the Multi Material Unit 2.0) to load a new "
"filament during a tool change (when executing the T code). This time is "
"added to the total print time by the G-code time estimator."
msgstr ""
"Tiempo que tarda el firmware de la impresora (o de la Unidad Multi Material "
"2.0) en cargar un nuevo filamento durante un cambio de cabezal (al ejecutar "
"el T-Code). El estimador de tiempo del G-Code añade este tiempo al tiempo "
"total de impresión."

=======
>>>>>>> main

<<<<<<< patch-1
msgid ""
"Time for the printer firmware (or the Multi Material Unit 2.0) to unload a "
"filament during a tool change (when executing the T code). This time is "
"added to the total print time by the G-code time estimator."
msgstr ""
"Tiempo que tarda el firmware de la impresora (o de la Unidad Multi Material "
"2.0) en descargar el filamento durante el cambio de cabezal (al ejecutar "
"el T-Code). El estimador de tiempo del G-Code añade este tiempo al tiempo "
"total de impresión."

=======
>>>>>>> main

@gatosardina
Copy link
Contributor Author

Btw, don't merge it yet, i'll add trnaslations for the new msgids, check if more updates to existing msgids were introduced

@gatosardina
Copy link
Contributor Author

Added new translations for the new msgids and updated the existing translations for some updated msgids
Ready once again for review and merge

@gatosardina gatosardina marked this pull request as draft August 28, 2024 07:05
@gatosardina gatosardina marked this pull request as ready for review August 28, 2024 07:05
@gatosardina
Copy link
Contributor Author

Fixed the strings breaking the check

@gatosardina
Copy link
Contributor Author

Idk what that means?

I checked a few other translation files and the referenced msgids and msgstr look the same, including the #, c-format bits and stuff

I did change the string legths of the last error, which seemed like a different error and a bit too long

@gatosardina
Copy link
Contributor Author

Aight it should be all good now, the msgfmt format check throws no errors to me:
image

Copy link
Owner

@SoftFever SoftFever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good
Thank you!

@SoftFever SoftFever merged commit 9e3969b into SoftFever:main Sep 3, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants