Extrusion Rate Smoothing: Round speed values to prevent needless & trivial speed fluctuations #5911
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
igiannakas
changed the title
…ed-values-to-prevent-unecessary-minor-speed-fluctuations
igiannakas
deleted the
Extrusion-Rate-Smoothing-Round-speed-values-to-prevent-unecessary-minor-speed-fluctuations
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently extrusion rate smoothing outputs a float to the set speed command. However this results on occasion in trivial speed fluctuations midway through continuous speed segments like seen below. This may or may not have an effect on print output; however it should be addressed to eliminate redundant gcode commands.
By rounding the speed to whole numbers this issue is eliminated, while also allowing speed adjustments to continue to be emitted where the speed delta is more than 1mm/sec