Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add missing includes #5691

Merged
merged 1 commit into from
Jun 29, 2024
Merged

add missing includes #5691

merged 1 commit into from
Jun 29, 2024

Conversation

schiele
Copy link
Contributor

@schiele schiele commented Jun 13, 2024

Building without precompiled header support revealed some missing includes that are added with this change for code health purposes. Those missing includes were hidden by precompiled header support due to the fact that the precompiled header file provides some definitions despite not being defined in directly or indirectly included header files.

Building without precompiled header support revealed some missing
includes that are added with this change for code health purposes.
Those missing includes were hidden by precompiled header support due to
the fact that the precompiled header file provides some definitions
despite not being defined in directly or indirectly included header
files.
Copy link
Owner

@SoftFever SoftFever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thanks!

@SoftFever SoftFever merged commit f5c5f32 into SoftFever:main Jun 29, 2024
12 checks passed
@schiele schiele deleted the missingincludes branch June 29, 2024 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants