-
-
Notifications
You must be signed in to change notification settings - Fork 833
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Potential fix for other layers bed temperature not applied #5546
Potential fix for other layers bed temperature not applied #5546
Conversation
Looking at the change I see why it is hard to reproduce: That is due to C++ standards https://en.cppreference.com/w/cpp/language/default_initialization
|
Exactly this. Which puzzles me as to why the constructor for this variable was commented out - this change was introduced in Bambu studio when porting prusa slicer since its first release and inherited over by orca. However I cannot understand why Bambu would remove the constructor initialisation for this 🤔 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking care of this issue.
I merge it s omore people can test it.
thx! its a trivial change, shouldn't break anything :) :P (famous last words :P ) |
Can you attach a project file so we can see/replicate the issue please? |
You can enable multiple plates on your printer profile (printer settings). Then all the plates will show in your filament profiles |
Description
On occasion the second layer bed temperature was not set according to the filament preferences. This PR aims to introduce a fix for this. This issue seems to have been present since v1.6.4 or earlier.
This is a particularly difficult one to reproduce as it doesn't happen repeatably.
Requesting community testers to validate the fix.
Test needed:
To see the Gcode window press key "C" on your keyboard. Navigate using the sliders to the second layer and at the start of it as shown in the screenshots below.
Asking for testers as its been particularly difficult to a) replicate that the issue is happening as its sporadic and b) validate that the fix is working.
When testing please confirm with your existing installation that the issue is happening first before trying the PR build. Please comment back below on whether a) it happened to you in the current build you're using alongside the version number you're running and b) if this PR fixed it or not.
When it works it should look like the below (line 774)
If it doesn't work it will look like this (line 773 only, no set bed temperature present)
Tests performed
As above.
I think that this PR also causes the bed temperature to always be set on the second layer but this also needs testing... Whether this is an issue or not remains open for discussion as its an extra Gcode command that is not needed but not harmful as the printer is already operating at that bed temperature so it will be just ignored.
Fixes #5485
Fixes #4676
Fixes #3015
Fixes #1853