Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix measure gizmo "Copy to Clipboard" button icon for dark mode #5230

Merged
merged 1 commit into from
May 2, 2024
Merged

Fix measure gizmo "Copy to Clipboard" button icon for dark mode #5230

merged 1 commit into from
May 2, 2024

Conversation

yw4z
Copy link
Contributor

@yw4z yw4z commented May 2, 2024

Problem is both shares same ID on code

const wchar_t ClipboardBtnDarkIcon       = 0x0836;
const wchar_t PrevArrowBtnIcon            = 0x0836;

Before

Screenshot-20240502020321

After

Screenshot-20240502042330

@yw4z yw4z marked this pull request as ready for review May 2, 2024 01:36
SoftFever
SoftFever approved these changes May 2, 2024
View reviewed changes
Copy link
Owner

@SoftFever SoftFever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!
Thanks

@SoftFever SoftFever merged commit 91d7f07 into SoftFever:main May 2, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SoftFever SoftFever SoftFever approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yw4z @SoftFever