-
-
Notifications
You must be signed in to change notification settings - Fork 833
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Dark Mode issues on Linux(via LAB) #5044
Conversation
Signed-off-by: Jamin W. Collins <jamin.collins@gmail.com>
Signed-off-by: Jamin W. Collins <jamin.collins@gmail.com>
Signed-off-by: Jamin W. Collins <jamin.collins@gmail.com>
Signed-off-by: Jamin W. Collins <jamin.collins@gmail.com>
Signed-off-by: Jamin W. Collins <jamin.collins@gmail.com>
This also fixes a light mode issue #3936, and possibly others. |
First of all, thank you for your effort in fixing this issue once and for all! 😃👍Unfortunately, not all of the fixes mentioned above work for me on my machine with the current build: https://github.com/SoftFever/OrcaSlicer/actions/runs/8708611679?pr=5044 Not working:
Could not test:
Everything else you mentioned above works. 👍 setup
|
Signed-off-by: Jamin W. Collins <jamin.collins@gmail.com>
fafe5c7
to
ae7975c
Compare
@jamincollins In However I'm not sure if that was present prior to your latest changes. Off-topic: 😅 Absolutely off-topic:
thanks in advance |
I am not able to reproduce this on Arch or Manjaro.
Please create a separate enhancement request for this.
Please create a separate enhancement request for this. |
Awesome! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
This should address most (if not all) dark mode issues.
I've added routines based on LAB color space in an effort to ensure that foreground colors are not the same (or similar) to background colors.
https://en.wikipedia.org/wiki/CIELAB_color_space
I'm sure there are other areas and dialogs these changes fix. While there are some targeted changes that were needed, the core is a generalized solution that should just work for most areas.
Screenshots/Recordings/Graphs
Tabs
Before
After
Custom Gcode Editor
Before
After
Export Configs
Before
After
Network Tests
Before
After
Printer Settings X/Y Fields
Before
After
Rename Plate
Before
After
Send G-Code
Before
After
Unsaved changes
Before
After
Tests
Built and tested locally on Arch Linux. I did need to revert commit 1bb8fad due to instability it introduced, see #5030.