Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reload All and Project Path #4903

Merged
merged 16 commits into from
Apr 30, 2024
Merged

Reload All and Project Path #4903

merged 16 commits into from
Apr 30, 2024

Conversation

chshkhr
Copy link
Contributor

@chshkhr chshkhr commented Apr 6, 2024

Description

  1. Reload All Objects
  2. Info about Source Path of the object selected

Screenshots

screenshot 4
screenshot 5

}
if (!found) {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you explain a bit the changes here?

Copy link
Contributor Author

@chshkhr chshkhr Apr 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the file not found in the current directory and exists on the initial file path it will be reloaded from there. Otherwise user will be prompted to select file manually.

So the file in the current directory has priority on the sorce file. This allows to copy project file to other directory, press Reload All and have same project with new STL files loaded.

But if you didn't move the project file to other place where new STL files exist Reload All will work the same way as before these changes were made.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the file not found in the current directory and exists on the initial file path it will be reloaded from there. Otherwise user will be prompted to select file manually.

This logic change sounds not very right to me.
The initial file path should have the priority IMO. It's also the logic in PS, can we revert the change?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure. It's better to have Reload All with another logic in the main branch than not to have at all)
I will continue using this logic.

Copy link
Owner

@SoftFever SoftFever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure. It's better to have Reload All with another logic in the main branch than not to have at all)
I will continue using this logic.

I'm not sure if I understand it.
Can you clarify?

@chshkhr
Copy link
Contributor Author

chshkhr commented Apr 22, 2024

I'm not sure if I understand it. Can you clarify?

This logic works the same way as original one untill you copy amf project to another directory where new stl files with the same names exist. It's very convenient for me as a 3D designer when I have several versions of a model. Different sizes for instance. You simply copy project to another folder, Reload All and you have new version ready to print.

@SoftFever
Copy link
Owner

I'm not sure if I understand it. Can you clarify?

This logic works the same way as original one untill you copy amf project to another directory where new stl files with the same names exist. It's very convenient for me as a 3D designer when I have several versions of a model. Different sizes for instance. You simply copy project to another folder, Reload All and you have new version ready to print.

I see. I understand this is convenient for this special case.
On the other hand, it's counterintuitive and will certainly confuse many users. So, I'm inclined not to include this change.

@chshkhr
Copy link
Contributor Author

chshkhr commented Apr 23, 2024

I'm not sure if I understand it. Can you clarify?

This logic works the same way as original one untill you copy amf project to another directory where new stl files with the same names exist. It's very convenient for me as a 3D designer when I have several versions of a model. Different sizes for instance. You simply copy project to another folder, Reload All and you have new version ready to print.

I see. I understand this is convenient for this special case. On the other hand, it's counterintuitive and will certainly confuse many users. So, I'm inclined not to include this change.

The users wil not certainly even notice the difference but you are owner and you decide.

@SoftFever
Copy link
Owner

I'm not sure if I understand it. Can you clarify?

This logic works the same way as original one untill you copy amf project to another directory where new stl files with the same names exist. It's very convenient for me as a 3D designer when I have several versions of a model. Different sizes for instance. You simply copy project to another folder, Reload All and you have new version ready to print.

I see. I understand this is convenient for this special case. On the other hand, it's counterintuitive and will certainly confuse many users. So, I'm inclined not to include this change.

The users wil not certainly even notice the difference but you are owner and you decide.

I agree that in most cases, it won't cause any difference.
However, when issues do arise, users will be completely lost about what's happening. ;)
If we could revert the changes in this specific part, that would be great.

@chshkhr
Copy link
Contributor Author

chshkhr commented Apr 29, 2024

The users wil not certainly even notice the difference but you are owner and you decide.

I agree that in most cases, it won't cause any difference. However, when issues do arise, users will be completely lost about what's happening. ;) If we could revert the changes in this specific part, that would be great.

I agree. Do you want me to change the pool request or can you do it yourself?

@SoftFever
Copy link
Owner

The users wil not certainly even notice the difference but you are owner and you decide.

I agree that in most cases, it won't cause any difference. However, when issues do arise, users will be completely lost about what's happening. ;) If we could revert the changes in this specific part, that would be great.

I agree. Do you want me to change the pool request or can you do it yourself?

Please go ahead and change the PR. Appreciate it.

@chshkhr
Copy link
Contributor Author

chshkhr commented Apr 30, 2024

The users wil not certainly even notice the difference but you are owner and you decide.

I agree that in most cases, it won't cause any difference. However, when issues do arise, users will be completely lost about what's happening. ;) If we could revert the changes in this specific part, that would be great.

I agree. Do you want me to change the pool request or can you do it yourself?

Please go ahead and change the PR. Appreciate it.

Done

Copy link
Owner

@SoftFever SoftFever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
Thank you!

@SoftFever SoftFever merged commit 6d19e2d into SoftFever:main Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants