Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix syntax errors in CR-10 SE G-Code #4769

Merged
merged 1 commit into from
Mar 30, 2024

Conversation

cochcoder
Copy link
Contributor

No description provided.

@cochcoder
Copy link
Contributor Author

Does it make a difference either \n is /n in the start or end G-Code?

Copy link
Owner

@SoftFever SoftFever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch.
Thanks

@SoftFever
Copy link
Owner

Does it make a difference either \n is /n in the start or end G-Code?

Yea, \n means start a newline, application will automatically substitute them
While /n is a normal string, which can cause trouble as it will send as is to the printer

@SoftFever SoftFever merged commit e82ea69 into SoftFever:main Mar 30, 2024
1 check passed
@cochcoder cochcoder deleted the CR-10-SE-G-Code-Fix branch March 30, 2024 01:53
@Zarin-Igor
Copy link

Hello, thanks for adding Ender CR 10 SE. but unfortunately the cut doesn't work for me
Снимок экрана 2024-04-01 212905

@cochcoder
Copy link
Contributor Author

@Zarin-Igor I am aware of this issue and I have a PR that fixes it. Can you confirm that this fixes it?

@Zarin-Igor
Copy link

@cochcoder I'm not very computer savvy, I followed the link to download the latest version and reinstalled... it didn't help, the error is the same. I hope I helped.

@rcpn99
Copy link

rcpn99 commented Apr 2, 2024

I downloaded and installed the latest version for Windows yesterday.
I'm getting the same error.

@Zarin-Igor
Copy link

Am I correct in understanding that this will be fixed in the next public updates? and how often are public updates made? Thank you, sorry if the question is in the wrong place...

@cochcoder
Copy link
Contributor Author

Am I correct in understanding that this will be fixed in the next public updates?

Most likely

and how often are public updates made?

I imagine that they're usually made once enough features/bugs are fixed and the code is in good standing for when even more issues are reported.

SoftFever pushed a commit that referenced this pull request Apr 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants