Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add overhang threshold for scarf joint seam #4725

Merged
merged 1 commit into from
Mar 27, 2024
Merged

Conversation

SoftFever
Copy link
Owner

@SoftFever SoftFever commented Mar 26, 2024

I didn't originally plan to add this feature to 2.0 as I wanted to do some more tests.
However, it turns out I don't have time to do more testing, so I will release it for more people to test.
Screenshot 2024-03-27 at 12 23 56 AM

@discip
Copy link
Contributor

discip commented Mar 26, 2024

@SoftFever
Is the value supposed to be expressed in % (percent) rather than in ° (degree)?

@vgdh
Copy link
Contributor

vgdh commented Mar 26, 2024

@SoftFever Is the value supposed to be expressed in % (percent) rather than in ° (degree)?

I think percent is more representative, because overhang percent may be different with the same incline degree because different line width.

@SoftFever
Copy link
Owner Author

Yeah, unsupported area of the perimeter can describe the overhang precisely. If we use angle, the overhang situation will be very different between 0.1 layer height to 0.3 layer height even if the angle is same.

@SoftFever SoftFever merged commit dcb8d09 into main Mar 27, 2024
12 checks passed
@SoftFever SoftFever deleted the feature/overhang_scarf branch March 27, 2024 14:02
@psiberfunk
Copy link

@SoftFever , I think this is a good compromise/hack for overhangs, however I think we might be able to get more fundamental improvement out of #4386. Have you considered if that's an easy or hard thing to do ?

SoftFever added a commit that referenced this pull request Apr 13, 2024
add overhang threshold for scarf joint seam
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants