Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Creality Ender-3 S1 Plus #4674

Merged
merged 23 commits into from
Mar 29, 2024
Merged

Conversation

cochcoder
Copy link
Contributor

@cochcoder cochcoder commented Mar 24, 2024

Closes #4669, closes #3707

@cochcoder
Copy link
Contributor Author

Marking this as a draft as I am getting lots of feedback from Gozania in #4669

@cochcoder cochcoder marked this pull request as draft March 25, 2024 01:25
@cochcoder
Copy link
Contributor Author

cochcoder commented Mar 27, 2024

@SoftFever I am running into a strange issue where even though I list the correct bed model/texture to use, they are not. What am I missing? Even when I tell the program what texture should be used, it isn't shown, while the model is.

What is shown:
whatitisnt

What it should look like:
whatitshouldbe

@cochcoder cochcoder marked this pull request as ready for review March 28, 2024 18:38
@cochcoder
Copy link
Contributor Author

Ok, everything should be working now!

@SoftFever SoftFever merged commit 7910e2a into SoftFever:main Mar 29, 2024
1 check passed
@cochcoder cochcoder deleted the Ender-3-S1-Plus branch March 29, 2024 12:43
SoftFever pushed a commit that referenced this pull request Apr 13, 2024
* Add Creality Ender-3 S1 Plus

* Misc

* Fix nozzle_diameter

* Add printer_variant value

* Change build plate model/texture to use Ender-3 V3 SE

* Enable mesh leveling

* Up max travel acceleration to 5000

* Enable infill_combination

* Add Draft profiles

* Change buildplate model/texture

* Fix build plate model

* Add retraction & detraction speed & change retraction length

* Add filament_ to the beginning

* Revert retraction & detraction speed & retraction length

* Tests

Trying to change retract and detract speed as well as retraction length
Also trying to have Z-hop only happen on top layers

* Apply new values to other nozzles

* disable z_hop

* Lower build plate model

* Resolve merge conflicts

* temporarily remove Ender-3 S1 Plus

* Re-add Ender-3 S1 Plus
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Please add profile for Creality Ender 3 S1 Plus Add Printer Model Creality Ender 3 S1 Plus
2 participants