Touchpad-friently 3d navigation #4598
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add camera navigation style config option as a preparation for introduction of touchpad style navigation
Implement FreeCAD-inspired touchpad-friendly camera operation mode: - Shift+move: panning - Alt+move: rotation Set "Camera mode" to "Touchpad" in settings menu to activate this mode.
SoftFever
added
wait for response
SoftFever
reviewed
Apr 3, 2024
src/slic3r/GUI/GLCanvas3D.cpp
Outdated
| @@ -4452,6 +4456,24 @@ void GLCanvas3D::on_set_focus(wxFocusEvent& evt) | |||
| m_tooltip_enabled = true; | |||
| } | |||
|
|
|||
| bool GLCanvas3D::is_camera_rotate(const wxMouseEvent& evt) const | |||
| { | |||
| if (wxGetApp().app_config->get("camera_navigation_style") == "1") { | |||
There was a problem hiding this comment.
Might be better to cache this value as member variable to avoid uncessary overhead as this is called in every mouse event.
There was a problem hiding this comment.
Updated that code.
Now this setting is cached on canvas focus.
I've also added forced focus for the canvas on preferences window close. This helps to solve 2 things:
- Force update setting value (which also could be applied to "zoom_to_mouse", "reverse_mouse_wheel_zoom" and "use_free_camera")
- User could immediately use 3D view hotkeys without clicking on a view first.
SoftFever
reviewed
Apr 3, 2024
src/slic3r/GUI/GLCanvas3D.cpp
Outdated
|
|
||
| bool GLCanvas3D::is_camera_pan(const wxMouseEvent& evt) const | ||
| { | ||
| if (wxGetApp().app_config->get("camera_navigation_style") == "1") { |
|
Works like a charm ;) |
|
I made a screen cap which demonstrates this feature in action. Default navigation mode: nav-default2.mp4"Touchpad" navigation mode: nav-touchpad2.mp4This navigation modes splits scene control over two hands making scene control easier for devices like touchpad or some trackballs. |
Cache current navigation style on canvas focus, do not request settings value each mouse event.
Explicitly force focus 3D preview pane on closing preferences window. This allows preferences be updated only once without checking current value each input event. Another benefit is to have 3D view in focus is that user could immediatelly use 3d-view shortcuts like Ctrl+<1..7> without clicking to the 3D view first.
powpingdone
pushed a commit
to powpingdone/OrcaSlicer
that referenced
this pull request
Apr 10, 2024
* gui: camera navigation style option Add camera navigation style config option as a preparation for introduction of touchpad style navigation * gui: touchpa-friently 3d navigation Implement FreeCAD-inspired touchpad-friendly camera operation mode: - Shift+move: panning - Alt+move: rotation Set "Camera mode" to "Touchpad" in settings menu to activate this mode. * cache current navigation style in class member variable Cache current navigation style on canvas focus, do not request settings value each mouse event. * force focuse 3d preview on preferences window close Explicitly force focus 3D preview pane on closing preferences window. This allows preferences be updated only once without checking current value each input event. Another benefit is to have 3D view in focus is that user could immediatelly use 3d-view shortcuts like Ctrl+<1..7> without clicking to the 3D view first.
powpingdone
pushed a commit
to powpingdone/OrcaSlicer
that referenced
this pull request
Apr 11, 2024
* gui: camera navigation style option Add camera navigation style config option as a preparation for introduction of touchpad style navigation * gui: touchpa-friently 3d navigation Implement FreeCAD-inspired touchpad-friendly camera operation mode: - Shift+move: panning - Alt+move: rotation Set "Camera mode" to "Touchpad" in settings menu to activate this mode. * cache current navigation style in class member variable Cache current navigation style on canvas focus, do not request settings value each mouse event. * force focuse 3d preview on preferences window close Explicitly force focus 3D preview pane on closing preferences window. This allows preferences be updated only once without checking current value each input event. Another benefit is to have 3D view in focus is that user could immediatelly use 3d-view shortcuts like Ctrl+<1..7> without clicking to the 3D view first.
SoftFever
pushed a commit
that referenced
this pull request
Apr 13, 2024
* gui: camera navigation style option Add camera navigation style config option as a preparation for introduction of touchpad style navigation * gui: touchpa-friently 3d navigation Implement FreeCAD-inspired touchpad-friendly camera operation mode: - Shift+move: panning - Alt+move: rotation Set "Camera mode" to "Touchpad" in settings menu to activate this mode. * cache current navigation style in class member variable Cache current navigation style on canvas focus, do not request settings value each mouse event. * force focuse 3d preview on preferences window close Explicitly force focus 3D preview pane on closing preferences window. This allows preferences be updated only once without checking current value each input event. Another benefit is to have 3D view in focus is that user could immediatelly use 3d-view shortcuts like Ctrl+<1..7> without clicking to the 3D view first.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement FreeCAD-inspired touchpad navigation mode.
This mode makes 3d model inspection easier for devices with touchpad as the only pointer device.
Controls: