Falashforge 5M network support #4546
Conversation
|
Thank you @iherbak |
|
@Noisyfox I noticed you are working on SimplyPrint connection. |
|
Hi,
I reverted the files for easy merge.
Regards,
István
…On Mon, 18 Mar 2024 at 16:12, SoftFever ***@***.***> wrote:
@Noisyfox <https://github.com/Noisyfox> I noticed you are working on
SimplyPrint connection.
Can you help review this PR too?
—
Reply to this email directly, view it on GitHub
<#4546 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABH6KN4GO6LB4GFUZQG27M3YY375VAVCNFSM6AAAAABE3DBZNCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMBUGE4DANZTG4>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
LGTM |
|
We need that stuff |
|
I have started the build. Looking for testers who have this machine to test. |
SoftFever
added
the
Community testers wanted
I can give it a go |
|
Adding printer works correctly, uploading sending gcode over the network also working correctly.
EDIT: Correction, when you specify slashes in the gcode to upload, if you choose to only upload (not print) the file will not appear in the printers onboard storage.
|
I'm available to test - Just installed |
Does it work if you don't change the upload folder? I don't have this machine. |
Yes, it works correctly if you don't specify a subfolder. There doesn't seem to be any manual way to create a folder on the internal storage either, though the UI on the screen for starting a print will show/print from directories on a connected usb storage device. @iherbak @FlashforgeOfficial If it's not possible to create a folder on the onboard storage, can we change filename window that appears to not suggest it? Would it also be possible to sanitize any slashes in the filenames so that the print will upload and start successfully if someone does try it? Also, this might not be the correct place for this, but it would be handy if you could choose to level the bed before starting the print on OrcaSlicer, just like you can when starting print from the screen. |
|
Based on the experience with Flashprint.
On file upload it is disabled to input backslash in the file upload dialog,
so I guess this is not supported at all on the Flashforge's firmware
…On Thu, 21 Mar 2024 at 16:51, Jay Harkess ***@***.***> wrote:
Does it work if you don't change the upload folder? Many klipper system
don't support uploading g-code to a subfolder.
I don't have this machine. So I leave @iherbak
<https://github.com/iherbak> @FlashforgeOfficial
<https://github.com/FlashforgeOfficial> to answer.
Yes, it works correctly if you don't specify a subfolder.
There doesn't seem to be any manual way to create a folder on the internal
storage either, though the UI on the screen for starting a print will
show/print from directories on a connected usb storage device.
@iherbak <https://github.com/iherbak> @FlashforgeOfficial
<https://github.com/FlashforgeOfficial> If it's not possible to create a
folder on the onboard storage, can we change filename window that appears
to not suggest it? Would it also be possible to sanitize any slashes in the
filenames so that the print will upload and start successfully if someone
does try it?
Also, this might not be the correct place for this, but it would be handy
if you could choose to level the bed before starting the print on
OrcaSlicer, just like you can when starting print from the screen.
—
Reply to this email directly, view it on GitHub
<#4546 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABH6KN3BUB3PKEMQK6TAXEDYZL6W3AVCNFSM6AAAAABE3DBZNCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMJSG4ZTMOBTGE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Thanks |
The build_orca.yml should not be merged as it is tailored to my repo, but the rest of the commits
Thanks