Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add elephant foot compensation over multiple layers #2254

Merged
merged 1 commit into from
Sep 30, 2023
Merged

Add elephant foot compensation over multiple layers #2254

merged 1 commit into from
Sep 30, 2023

Conversation

bitingsock
Copy link
Contributor

@SoftFever
Copy link
Owner

@bitingsock
First of all, thanks for the PR!

Do you mind to add more details about the problem the PR is trying to solve?
Some before and after photo for comparison will be helpful

@bitingsock
Copy link
Contributor Author

The problem is basically detailed here:
prusa3d/PrusaSlicer#6276

By definition elephant's foot is not just a single layer problem, albeit on most printers a single layer compensation fixes 90% or more of the problem. In CAD we can easily put a substantial chamfer to fix it but that is not always a possibility.

https://youtu.be/zlgR3rHg4p8?si=X3kndwDf-0lYNEcY&t=573 at around 9:30 explains it well.

@bitingsock
Copy link
Contributor Author

Note that this feature actually already exists in SuperSlicer which, I believe, is what the original write up was back-ported from.
https://github.com/supermerill/SuperSlicer/blob/45d0532845b63cd5cefe7de7dc4ef0e0ed7e030a/src/libslic3r/PrintObjectSlice.cpp#L986

Copy link
Owner

@SoftFever SoftFever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SoftFever
Copy link
Owner

@bitingsock Thanks for the PR and explainations.
Merged.

@SoftFever SoftFever merged commit bda8249 into SoftFever:main Sep 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants