set PA for RepRap #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SoftFever
requested changes
Dec 12, 2022
src/libslic3r/GCode.cpp
Outdated
| @@ -1395,7 +1395,7 @@ void GCode::_do_export(Print& print, GCodeOutputStream &file, ThumbnailsGenerato | |||
| file.write_format( | |||
| "; %s\n\n", | |||
| std::string( | |||
| std::string("generated by SuperSlicer " SLIC3R_VERSION " on ") + | |||
There was a problem hiding this comment.
I added this fake slicer ID so that Klipper's ECO system can recognize it.
I have added supports in Moonraker but there are other plugins(like the cancel objects script that need to be fixed).
Until then we need this fake slicer ID.
-SoftFever
There was a problem hiding this comment.
Thats fine it was only for my test
| @@ -224,6 +224,8 @@ std::string GCodeWriter::set_pressure_advance(double pa) const | |||
| else{ | |||
| if (FLAVOR_IS(gcfKlipper)) | |||
| gcode << "SET_PRESSURE_ADVANCE ADVANCE=" << std::setprecision(4) << pa << "; Override pressure advance value\n"; | |||
| else if(FLAVOR_IS(gcfRepRapFirmware)) | |||
There was a problem hiding this comment.
I cant find the variable for Extruder ID. For M572 D0 >- extruder ID
There was a problem hiding this comment.
Multi-extruder support is another rabbit hole ;)
|
@hliebscher thanks for the PR. -SoftFever |
SoftFever
approved these changes
Dec 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix for Pressure Advance for Reprap
take the right G Code M572 D0 Sx.xxxx