-
-
Notifications
You must be signed in to change notification settings - Fork 833
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
set PA for RepRap #19
Conversation
src/libslic3r/GCode.cpp
Outdated
@@ -1395,7 +1395,7 @@ void GCode::_do_export(Print& print, GCodeOutputStream &file, ThumbnailsGenerato | |||
file.write_format( | |||
"; %s\n\n", | |||
std::string( | |||
std::string("generated by SuperSlicer " SLIC3R_VERSION " on ") + |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added this fake slicer ID so that Klipper's ECO system can recognize it.
I have added supports in Moonraker but there are other plugins(like the cancel objects script that need to be fixed).
Until then we need this fake slicer ID.
-SoftFever
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thats fine it was only for my test
@@ -224,6 +224,8 @@ std::string GCodeWriter::set_pressure_advance(double pa) const | |||
else{ | |||
if (FLAVOR_IS(gcfKlipper)) | |||
gcode << "SET_PRESSURE_ADVANCE ADVANCE=" << std::setprecision(4) << pa << "; Override pressure advance value\n"; | |||
else if(FLAVOR_IS(gcfRepRapFirmware)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I cant find the variable for Extruder ID. For M572 D0 >- extruder ID
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Multi-extruder support is another rabbit hole ;)
@hliebscher thanks for the PR. -SoftFever |
fix for Pressure Advance for Reprap
take the right G Code M572 D0 Sx.xxxx