Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add spacenavd support #1769

Merged
merged 1 commit into from
Aug 19, 2023
Merged

Add spacenavd support #1769

merged 1 commit into from
Aug 19, 2023

Conversation

RealDeuce
Copy link
Contributor

@RealDeuce RealDeuce commented Aug 11, 2023

Spacenavd is an open source driver for 6dof 3D mice. When using libspnav, each program doesn't need to add support for new (or old) devices, and they don't need exclusive access to the serial or USB device, allowing it to be used by multiple programs open at the same time (ie: FreeCAD and OrcaSlicer) rather than only the first one to be opened getting the d vice and the other locked out.

@SoftFever
Copy link
Owner

Thanks @RealDeuce
But could you please provide details about what problem/feature does this PR do?
I know it's about spacemouse, but without context it's hard to do code review.

@RealDeuce
Copy link
Contributor Author

Initial SS commit to do the same thing: supermerill/SuperSlicer@2b908bc

@RealDeuce
Copy link
Contributor Author

I updated the commit comment:

Spacenavd is an open source driver for 6dof 3D mice. When using libspnav, each program doesn't need to add support for new (or old) devices, and they don't need exclusive access to the serial or USB device, allowing it to be used by multiple programs open at the same time (ie: FreeCAD and OrcaSlicer) rather than only the first one to be opened getting the d vice and the other locked out.

Copy link
Owner

@SoftFever SoftFever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't personally test this.
But the changes looks good and safe to me.

@SoftFever
Copy link
Owner

Thank you very much!
Merged.

@SoftFever SoftFever merged commit 27eb7bb into SoftFever:main Aug 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants