Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed spanish translation and kingroon profiles added #1572

Merged
merged 43 commits into from
Jul 23, 2023

Conversation

tadeu2
Copy link
Contributor

@tadeu2 tadeu2 commented Jul 22, 2023

Fixed a lot of spanish strings and expressions from last translation, Kingroon profile added.

tadeu2 and others added 30 commits June 30, 2023 13:24
	modified:   bbl/i18n/es/OrcaSlicer_es.mo
OrcaSlicer_es.po finished
	modified:   resources/i18n/es/OrcaSlicer.mo
Added es_ES to text.js (spanish strings)
Added Kp3s and kp5l printers
CAMBIOS EN CUARTEL
@tadeu2 tadeu2 closed this Jul 23, 2023
@tadeu2 tadeu2 reopened this Jul 23, 2023
Copy link
Owner

@SoftFever SoftFever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SoftFever
Copy link
Owner

Thanks @tadeu2. Appreciate it.

The changes look good.

In the future, it would be great to have two PRs in cases like this (one for translation and one for Kingroon profiles) so that it's easy to track.

@SoftFever SoftFever merged commit cccc857 into SoftFever:main Jul 23, 2023
@tadeu2
Copy link
Contributor Author

tadeu2 commented Jul 23, 2023

Ok, sorry. I will do.

@SoftFever
Copy link
Owner

Ok, sorry. I will do.

Not at all.
Really appreciate your work :)

@tadeu2
Copy link
Contributor Author

tadeu2 commented Jul 24, 2023 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants