Optimise sandwich wall mode when perimeters are shared with multiple islands(Arachne only) #1352
Conversation
src/libslic3r/PerimeterGenerator.cpp
Outdated
| } | ||
| if(outer >-1 && first_internal>-1 && second_internal>-1){ //found perimeters to re-order? | ||
| swapped_extrusions[0] = ordered_extrusions[outer]; // get the extrusions that need re-ordering into temporary array. |
There was a problem hiding this comment.
It's better to use swap function here instead of the a temporary vector.
|
The overall logic seems fine to me. It could be optimized or simplified. I have some suggestions in my comment. Let me know if you want me to commit changes into this branch directly. If not, I'm happy to let you do it yourself. |
I couldn’t get the swap function for some reason to work consistently - I’m sure it’s a debug issue but couldn’t find a solution to it. I’d appreciate your help on that please. |
|
@igiannakas |
SoftFever
changed the title
Looks great, love the clean up especially on the reordering - moving away from allocating an array of 3 to a single one is a good move! Looking good to go I think? |
|
Cool. Good to merge. Currently this optimisation apply to Arachne, do you want to optimise the classic wall generator(in process_classic() function)? |
PR containing the change in approach to handling sandwich mode when using Arachne engine.
In a nutshell instead of treating the perimeters as inside to outside and re-ordering the last extrusion it flips it to treat them as outside to inside and swaps the order of printing the third wall with the outer perimeter so the order is internal, external, internal and then the remaining internal walls from the outside - in.
This means that when less than 3 extrusions exist the wall is treated as outside to inside, leading to a better surface finish as there is no variation due to printing an external perimeter with and without an adjoining internal perimeter
This is a revised version of the PR #751 addressing issue #745 with more extensive logic on the wall ordering to ensure that all cases where an external perimeter is present on an island are re-ordered correctly, even if there are multiple external perimeters within the same island.