Merge pull request #3 from Sofimedina/assignment-reviewed

assigmente reviewed fixes
Sofimedina · Feb 7, 2023 · 49bfee0 · 49bfee0
2 parents 27620be + 3d1b436
commit 49bfee0
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 6 deletions.
diff --git a/src/main/java/guru/springframework/sfgdi/SfgDiApplication.java b/src/main/java/guru/springframework/sfgdi/SfgDiApplication.java
@@ -11,7 +11,7 @@ public class SfgDiApplication {
 	public static void main(String[] args) {
 		ApplicationContext ctx = SpringApplication.run(SfgDiApplication.class, args);
 
-		PetController petController =(PetController) ctx.getBean("petController");
+		PetController petController = ctx.getBean("petController", PetController.class);
 		System.out.println("--- The Best Pet is ---");
 		System.out.println(petController.whichPetIsTheBest());
 

diff --git a/src/main/java/guru/springframework/sfgdi/controllers/PetController.java b/src/main/java/guru/springframework/sfgdi/controllers/PetController.java
@@ -15,7 +15,6 @@ public PetController(PetService petService) {
         this.petService = petService;
     }
 
-
     public String whichPetIsTheBest(){
         return petService.getPetType();
     }

diff --git a/src/main/java/guru/springframework/sfgdi/services/CatPetService.java b/src/main/java/guru/springframework/sfgdi/services/CatPetService.java
@@ -6,8 +6,8 @@
 /**
  * Created by jt on 12/28/19.
  */
+@Service
 @Profile("cat")
-@Service("petService")
 public class CatPetService implements PetService {
     @Override
     public String getPetType() {

diff --git a/src/main/java/guru/springframework/sfgdi/services/DogPetService.java b/src/main/java/guru/springframework/sfgdi/services/DogPetService.java
@@ -7,9 +7,8 @@
  * Created by jt on 12/28/19.
  */
 @Profile({"dog", "default"})
-@Service("petService")
-public class DogPetService implements PetService{
-    @Override
+@Service
+public class DogPetService implements PetService {
     public String getPetType(){
         return "Dogs are the best!";
     }