feat: expose persistent playout state on LSG#1644
Open
Julusian wants to merge 3 commits intoSofie-Automation:mainfrom
Open
feat: expose persistent playout state on LSG#1644Julusian wants to merge 3 commits intoSofie-Automation:mainfrom
Julusian wants to merge 3 commits intoSofie-Automation:mainfrom
Conversation
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
About the Contributor
This pull request is posted on behalf of the BBC
Type of Contribution
This is a: Feature
New Behavior
It would be useful to expose some arbitrary playout state via the LSG without having to insert (and then find it) in random pieces.
We already have this concept of
PersistentPlayoutStatewithin the blueprints, which is modifiable in the blueprint playout methods.This expands that to have a 'public' and 'private' forms of that, similar to how we have publicData and privateData elsewhere.
The public version is then exposed via LSG, with the private one kept as before.
Because we have this BlueprintPlayoutPersistentStore wrapper around the state, to allow us to detect changes without a diff, instead of adding another property to blueprint methods, this has been expanded to wrap both versions of this state.
Testing
Affected areas
Time Frame
Other Information
Status