feat: replace wasActive in onRundownActivate with context
#1514
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rentState in RundownActivationContext. Also changed the algorithm in handleResetRundownPlaylist, so that activateRundownPlaylist always runs This is to provide better context for blueprints, so that they can determine if a RundownPlaylist is being Activated from idle, from Rehersal or a Reset
Julusian
requested changes
Sep 2, 2025
# Conflicts: # packages/job-worker/src/playout/activePlaylistActions.ts # packages/job-worker/src/playout/activePlaylistJobs.ts # packages/job-worker/src/playout/lib.ts
|
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
Julusian
approved these changes
Sep 8, 2025
Member
Julusian
left a comment
Julusian
left a comment
There was a problem hiding this comment.
There is a linter and unit test failure, both look to be quick fixes
jstarpl
pushed a commit
to nrkno/sofie-nrk-core
that referenced
this pull request
Dec 12, 2025
…tomation#1514) feat: replace `wasActive` in onRundownActivate with previousState¤tState in RundownActivationContext. Also changed the algorithm in handleResetRundownPlaylist, so that activateRundownPlaylist always runs This is to provide better context for blueprints, so that they can determine if a RundownPlaylist is being Activated from idle, from Rehersal or a Reset
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the Contributor
This pull request is posted on behalf of the NRK.
Type of Contribution
This is a: BREAKING CHANGE to the
blueprint-integrationinterface.Current Behavior
Use case:
We (NRK) need to trigger a TSR Action from blueprints at the time a user does a "Reset Rundown".
The problem is that neither one of the blueprints
onRundownActivatenoronRundownDeactivatehooks are called upon a "Reset Rundown".New Behavior
This PR does two things:
activateRundownPlaylist(which does a reset internally)wasActivefromonRundownActivate?: (context: IRundownActivationContext, wasActive: boolean) => Promise<void>(this is a BREAKING CHANGE) and instead addspreviousStateandcurrentStatetoIRundownActivationContextThis allows our blueprints to trigger our TSR Action from
onRundownActivateTesting
Affected areas
This PR affects the blueprints-integration interface.
This PR potentially affects the Reset Rundown method.
Time Frame
We've merged this into our local R52 branch, we would like to get this merged into the in-development release.
Other Information
Status