Skip to content

fix: hover iframePreview was not updating when hovering directly from one pvw to the next #1511

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nytamin merged 1 commit into from
Sep 29, 2025
+10 −2
Merged

fix: hover iframePreview was not updating when hovering directly from one pvw to the next #1511

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions packages/webui/src/client/ui/PreviewPopUp/Previews/IFramePreview.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,8 @@ export function IFramePreview({ content }: IFramePreviewProps): React.ReactEleme

const onLoadListener = useCallback(() => {
if (content.postMessage) {
const url = new URL(content.href)
iFrameElement.current?.contentWindow?.postMessage(content.postMessage, url.origin)
// use * as URL reference to avoid cors when posting message with new reference:
iFrameElement.current?.contentWindow?.postMessage(content.postMessage, '*')
}
}, [content.postMessage, content.href])

Expand All @@ -31,6 +31,14 @@ export function IFramePreview({ content }: IFramePreviewProps): React.ReactEleme
return () => currentIFrame.removeEventListener('load', onLoadListener)
}, [onLoadListener])

// Handle postMessage updates when iframe is already loaded
useEffect(() => {
if (content.postMessage && iFrameElement.current?.contentWindow) {
// use * as URL reference to avoid cors when posting message with new reference:
iFrameElement.current.contentWindow.postMessage(content.postMessage, '*')
}
}, [content.postMessage, content.href])

const style: Record<string, string | number> = {}
if (content.dimensions) {
style['--preview-render-width'] = content.dimensions.width
Expand Down
Loading