Fix: input type of PM Quantel Accessor ISAURLs (SOFIE-4126) #1508
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cessors.${accessorId}.ISAUrls to an array of strings
…cessors.${accessorId}.serverId to an int and not a string
…mMediaStore accessor type
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Julusian
reviewed
Aug 25, 2025
packages/webui/src/client/ui/Settings/Studio/PackageManager/AccessorTableRow.tsx
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the Contributor
This pull request is posted on behalf of the NRK.
Type of Contribution
This is a:
Bug fix
Current Behavior
Package Manager failed with error message:
TypeError: this.accessor.ISAUrls.join is not a functionNew Behavior
Sofie GUI now saves ISAUrls as arrays of strings, as was intended
Testing
Affected areas
This PR affects Package Manager
Status
…cessors.${accessorId}.ISAUrls to an array of strings