fix: Live Status Gateway subscription name check

[PeterC89]

About the Contributor

This pull request is posted on behalf of the BBC.

Type of Contribution

This is a:
Bug fix

Current Behaviour

Live status gateway subscriptions fail as the gateway doesn't actually setup any topics on startup.

New Behaviour

Live status gateway subscriptions work

Testing

• I have added one or more unit tests for this PR
• I have updated the relevant unit tests
• No unit test changes are needed for this PR

Affected areas

Live Status Gateway

Time Frame

Not urgent, but we would like to get this merged into the in-development release.

Other Information

Status

• PR is ready to be reviewed.
• The functionality has been tested by the author.
• Relevant unit tests has been added / updated.
• Relevant documentation (code comments, system documentation) has been added / updated.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.04%. Comparing base (c61bec6) to head (56823de).
Report is 13 commits behind head on release53.

Additional details and impacted files

@@              Coverage Diff              @@
##           release53    #1439      +/-   ##
=============================================
+ Coverage      54.00%   54.04%   +0.03%     
=============================================
  Files            404      404              
  Lines          73586    73586              
  Branches        5365     4926     -439     
=============================================
+ Hits           39737    39766      +29     
+ Misses         33721    33691      -30     
- Partials         128      129       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[jstarpl]

Hmm... Interesting. I see this code present in release51 as well, so I suspect those versions would also be affected, unless this is caused by some development dependency update? Could you elaborate on what the behavior before the fix is, so that I can check if we need to backport this to v1.51.x and v1.52.x?

[PeterC89]

It was broken by #1403 so should only be present in R53.

Effectively the enums prior to #1403 were setup so the key/value was the same meaning that the in check (checking for a key) worked.
Now the keys have new names as part of the types library meaning that the in check is invalid as it needs to check against the value.