fix: some snapshots not restoring correctly due to id generation order & publications lost errors

[Julusian]

About the Contributor

This pull request is posted on behalf of the BBC

Type of Contribution

This is a: Bug fix

Current Behavior

This contains a couple of fixes:

Some publications which use PromiseDebounce (specifically using the trigger() method), are not reporting errors due to the behaviour of PromiseDebounce. This adds some simple try/catch logging.

When restoring some snapshots, I was having issues with the ids in the ingest cache collections not lining up. This adjusts how the ids are generated to make those link up correctly.

Testing

• I have added one or more unit tests for this PR
• I have updated the relevant unit tests
• No unit test changes are needed for this PR

Affected areas

Time Frame

Other Information

Status

• PR is ready to be reviewed.
• The functionality has been tested by the author.
• Relevant unit tests has been added / updated.
• Relevant documentation (code comments, system documentation) has been added / updated.

[codecov]

Codecov Report

Attention: Patch coverage is 83.87097% with 5 lines in your changes missing coverage. Please review.

Project coverage is 56.55%. Comparing base (17106c7) to head (04b3998).
Report is 18 commits behind head on release52.

Files with missing lines	Patch %	Lines
meteor/server/publications/lib/rundownsObserver.ts	72.22%	5 Missing ⚠️

Additional details and impacted files

@@              Coverage Diff              @@
##           release52    #1422      +/-   ##
=============================================
- Coverage      56.57%   56.55%   -0.03%     
=============================================
  Files            408      408              
  Lines          73255    73258       +3     
  Branches        4665     4629      -36     
=============================================
- Hits           41445    41431      -14     
- Misses         31591    31608      +17     
  Partials         219      219              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.