Skip to content

Conversation

@jstarpl
Copy link
Contributor

@jstarpl jstarpl commented Mar 11, 2025

About the Contributor

This is a personal contribution.

Type of Contribution

This is a:

Bug fix

Current Behavior

The Contribution Guidelines are unclear on what the RFC should contain, who their target audience is, and when one should open one.

New Behavior

A couple of paragraphs have been added to explain:

  • Why the RFC's exist
  • Who is the target audience for the RFC
  • What is useful in an RFC
  • Where the discussion happens: either workshops or RFC comments, as needed

Testing

  • I have added one or more unit tests for this PR
  • I have updated the relevant unit tests
  • No unit test changes are needed for this PR

Affected areas

This PR affects the Contribution Guidelines

Time Frame

Not urgent, but I would like to get this merged into the master release, since it's project meta-documentation.

Other Information

Status

  • PR is ready to be reviewed.
  • The functionality has been tested by the author.
  • Relevant unit tests has been added / updated.
  • Relevant documentation (code comments, system documentation) has been added / updated.

@jstarpl jstarpl requested a review from a team as a code owner March 11, 2025 11:24
@codecov
Copy link

codecov bot commented Mar 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.99%. Comparing base (1a81bed) to head (e66e0e6).
Report is 6 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1402      +/-   ##
==========================================
+ Coverage   57.98%   57.99%   +0.01%     
==========================================
  Files         525      525              
  Lines       85218    85218              
  Branches     4440     4441       +1     
==========================================
+ Hits        49415    49424       +9     
  Misses      35770    35770              
+ Partials       33       24       -9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jstarpl jstarpl merged commit 4a7544c into master Apr 8, 2025
79 of 81 checks passed
@jstarpl jstarpl deleted the chore/contribution-guidelines-rfc-clarification branch April 8, 2025 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants