Skip to content

Fixed license generation using the purl endpoint #89

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 25, 2025
Merged

Fixed license generation using the purl endpoint #89

merged 1 commit into from
Jun 25, 2025

Conversation

dacoburn
Copy link
Collaborator

Root Cause

Python CLI was erroring out on generating license from both using the new diff endpoint and the license objects changing.

Fix

Added in logic to use the batch purl endpoint to retrieve the license details.

Public Changelog

  • Fixed the CLI to work with generating the license attribution again. The license_text property has been replaced with licenseDetails and licenseAttrib

@dacoburn dacoburn requested a review from a team as a code owner June 25, 2025 02:34
@dacoburn dacoburn requested review from pvdz and hemanthkini and removed request for a team June 25, 2025 02:34
@dacoburn dacoburn added the Product Changelog New features for the public changelog label Jun 25, 2025
@github-actions GitHub Actions
Copy link

🚀 Preview package published!

Install with:

pip install --index-url https://test.pypi.org/simple/ --extra-index-url https://pypi.org/simple socketsecurity==2.1.10.dev1

Docker image: socketdev/cli:pr-89

@dacoburn dacoburn merged commit ec01185 into main Jun 25, 2025
6 checks passed
@dacoburn dacoburn deleted the doug/fix-license-generation branch June 25, 2025 02:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Planeshifter Planeshifter Planeshifter approved these changes

@philidem philidem philidem approved these changes

@pvdz pvdz Awaiting requested review from pvdz pvdz is a code owner automatically assigned from SocketDev/eng

@hemanthkini hemanthkini Awaiting requested review from hemanthkini hemanthkini is a code owner automatically assigned from SocketDev/eng

Assignees
No one assigned
Labels
Product Changelog New features for the public changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dacoburn @Planeshifter @philidem