Skip to content

exclude .socket.facts.json from socket fix manifest upload #926

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 20, 2025
Merged

exclude .socket.facts.json from socket fix manifest upload #926

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion src/commands/fix/coana-fix.mts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ import { promises as fs } from 'node:fs'
import os from 'node:os'
import path from 'node:path'

import { DOT_SOCKET_DOT_FACTS_JSON } from '../../constants.mts'
import { joinAnd } from '@socketsecurity/registry/lib/arrays'
import { debugDir, debugFn } from '@socketsecurity/registry/lib/debug'
import { readJsonSync } from '@socketsecurity/registry/lib/fs'
Expand Down Expand Up @@ -88,8 +89,13 @@ export async function coanaFix(
const scanFilepaths = await getPackageFilesForScan(['.'], supportedFiles, {
cwd,
})
// Exclude any .socket.facts.json files that happen to be in the scan
// folder before the analysis was run.
const filepathsToUpload = scanFilepaths.filter(
p => path.basename(p).toLowerCase() !== DOT_SOCKET_DOT_FACTS_JSON,
)
const uploadCResult = await handleApiCall(
sockSdk.uploadManifestFiles(orgSlug, scanFilepaths),
sockSdk.uploadManifestFiles(orgSlug, filepathsToUpload),
{
description: 'upload manifests',
spinner,
Expand Down