Add option to pass a codec engine to the client#11
Open
BLineBrian wants to merge 1 commit intoSocketCluster:masterfrom
Open
Add option to pass a codec engine to the client#11BLineBrian wants to merge 1 commit intoSocketCluster:masterfrom
BLineBrian wants to merge 1 commit intoSocketCluster:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using a custom codec engine is supported for socketcluster clients communicating to worker instances, but there's no way to specify a codec for use between the workers and the broker instances.
There are performance implications here, but in our case the default codec was actually breaking communication with clients.
This is a small change to allow callers to override the codec engine for socketcluster server/worker communication with the broker. For things to work correctly, you also need to specific this same codec on the broker itself.