Fix find checkpoint #1304
Merged
Fix find checkpoint #1304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
yrong
reviewed
Oct 8, 2024
| endIndex := startIndex + 1 | ||
| iterations := uint64(0) | ||
|
|
||
| syncCommitteePeriod := h.protocol.Settings.SlotsInEpoch * h.protocol.Settings.EpochsPerSyncCommitteePeriod | ||
| totalStates := h.protocol.Settings.EpochsPerSyncCommitteePeriod * h.protocol.HeaderRedundancy // Total size of the circular buffer, | ||
| // https://github.com/paritytech/polkadot-sdk/blob/master/bridges/snowbridge/pallets/ethereum-client/src/lib.rs#L75 | ||
| for index := startIndex; index != endIndex; index = (index - 1 + totalStates) % totalStates { |
There was a problem hiding this comment.
I'd suggest to simplify the loop pattern to stop at(circle back to) the startIndex, something like:
for {
....
index = (index - 1 + totalStates) % totalStates
if index == startIndex {
log.Debug("loop finished, max iterations reached")
break
}
}
...
There was a problem hiding this comment.
That's a good point. 😅 Let me know what you think of ba114cf.
yrong
reviewed
Oct 9, 2024
Comment on lines
562
to
567
| index = (index - 1 + totalStates) % totalStates | ||
| if index == startIndex { | ||
| log.WithError(err).Debug("unable to find a relevant on-chain header, max iterations reached") | ||
| break | ||
| } | ||
|
|
There was a problem hiding this comment.
Better to move this to the end or we may miss the first item at startIndex.
There was a problem hiding this comment.
Good catch: 757581a Added a test for the condition too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.