Update from upstream #1123
Merged
Update from upstream #1123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
claravanstaden
force-pushed
the
update-from-upstream-22-jan
branch
from
febbec3
to
2d5929a
Compare
added 2 commits
January 23, 2024 08:32
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1123 +/- ##
==========================================
+ Coverage 75.08% 75.09% +0.01%
==========================================
Files 58 58
Lines 2464 2461 -3
Branches 72 72
==========================================
- Hits 1850 1848 -2
+ Misses 597 596 -1
Partials 17 17
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
claravanstaden
commented
Jan 23, 2024
Comment on lines
+25
to
+52
| [workspace.lints.rust] | ||
| suspicious_double_ref_op = { level = "allow", priority = 2 } | ||
|
|
||
| [workspace.lints.clippy] | ||
| all = { level = "allow", priority = 0 } | ||
| correctness = { level = "warn", priority = 1 } | ||
| complexity = { level = "warn", priority = 1 } | ||
| if-same-then-else = { level = "allow", priority = 2 } | ||
| zero-prefixed-literal = { level = "allow", priority = 2 } # 00_1000_000 | ||
| type_complexity = { level = "allow", priority = 2 } # raison d'etre | ||
| nonminimal-bool = { level = "allow", priority = 2 } # maybe | ||
| borrowed-box = { level = "allow", priority = 2 } # Reasonable to fix this one | ||
| too-many-arguments = { level = "allow", priority = 2 } # (Turning this on would lead to) | ||
| needless-lifetimes = { level = "allow", priority = 2 } # generated code | ||
| unnecessary_cast = { level = "allow", priority = 2 } # Types may change | ||
| identity-op = { level = "allow", priority = 2 } # One case where we do 0 + | ||
| useless_conversion = { level = "allow", priority = 2 } # Types may change | ||
| unit_arg = { level = "allow", priority = 2 } # stylistic | ||
| option-map-unit-fn = { level = "allow", priority = 2 } # stylistic | ||
| bind_instead_of_map = { level = "allow", priority = 2 } # stylistic | ||
| erasing_op = { level = "allow", priority = 2 } # E.g. 0 * DOLLARS | ||
| eq_op = { level = "allow", priority = 2 } # In tests we test equality. | ||
| while_immutable_condition = { level = "allow", priority = 2 } # false positives | ||
| needless_option_as_deref = { level = "allow", priority = 2 } # false positives | ||
| derivable_impls = { level = "allow", priority = 2 } # false positives | ||
| stable_sort_primitive = { level = "allow", priority = 2 } # prefer stable sort | ||
| extra-unused-type-parameters = { level = "allow", priority = 2 } # stylistic | ||
| default_constructed_unit_structs = { level = "allow", priority = 2 } # stylistic |
There was a problem hiding this comment.
Same lints as the polkadot-sdk.
yrong
reviewed
Jan 23, 2024
| @@ -21,8 +21,8 @@ use sp_runtime::{ | |||
| BuildStorage, FixedU128, MultiSignature, | |||
| }; | |||
| use sp_std::convert::From; | |||
| use xcm::v3::{prelude::*, MultiAssets, SendXcm}; | |||
| use xcm_executor::Assets; | |||
| use xcm::v4::{prelude::*, SendXcm}; | |||
There was a problem hiding this comment.
Seems the explicit v4 is unnecessary here, it's by default exposed in xcm::prelude
There was a problem hiding this comment.
Good point! Changed in b8515e6
yrong
reviewed
Jan 23, 2024
| @@ -16,7 +16,7 @@ use snowbridge_core::{ | |||
| }; | |||
| use sp_core::{H160, H256}; | |||
| use sp_std::{iter::Peekable, marker::PhantomData, prelude::*}; | |||
| use xcm::v3::prelude::*; | |||
| use xcm::v4::prelude::*; | |||
There was a problem hiding this comment.
added 2 commits
January 23, 2024 11:34
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes to our crates on the upstream polkadot-sdk.
Polkadot-sdk companion: Snowfork/polkadot-sdk#103