Skip to content
This repository has been archived by the owner on Oct 22, 2024. It is now read-only.

Deposit fee to beneficiary #137

Closed
wants to merge 11 commits into from
Closed

Deposit fee to beneficiary #137

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
7980ffc
Deposit fee left to beneficiary
yrong Apr 10, 2024
f28b8db
Replace AllCounted with All
yrong Apr 11, 2024
a7e19fa
Allow penpal to receive relay token & Update fixture for emulated tes…
yrong Apr 12, 2024
1a443b8
Fix taplo
yrong Apr 12, 2024
1f99789
Fix dependency
yrong Apr 12, 2024
81d98fe
Merge branch 'snowbridge' into ron/deposit-fee-to-beneficiary
yrong Apr 12, 2024
6570d9d
Update Cargo.toml
yrong Apr 12, 2024
54cd6a7
Fix breaking test
yrong Apr 12, 2024
9071372
Update fixture sending token to a non-existence account on AH
yrong Apr 13, 2024
7e0ddaa
Deposit only asset to beneficiary on destination chain
yrong Apr 15, 2024
8e94def
Remove changes unnecessary
yrong Apr 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions bridges/snowbridge/primitives/router/src/inbound/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -278,8 +278,8 @@ where
xcm: vec![
// Buy execution on target.
BuyExecution { fees: dest_para_fee_asset, weight_limit: Unlimited },
// Deposit asset to beneficiary.
DepositAsset { assets: Definite(asset.into()), beneficiary },
// Deposit both asset and fees to beneficiary.
DepositAsset { assets: Wild(AllCounted(2u32)), beneficiary },
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why AllCounted instead of All?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

f28b8db

// Forward message id to destination parachain.
SetTopic(message_id.into()),
]
Expand All @@ -289,8 +289,10 @@ where
},
None => {
instructions.extend(vec![
// Deposit asset to beneficiary.
DepositAsset { assets: Definite(asset.into()), beneficiary },
// Deposit both asset and fees to beneficiary so the fees will not get
// trapped. Another benefit is when fees left more than ED could be used to
// create the beneficiary account in case it does not exist.
DepositAsset { assets: Wild(AllCounted(2u32)), beneficiary },
]);
},
}
Expand Down
2 changes: 1 addition & 1 deletion cumulus/parachains/runtimes/testing/penpal/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -262,7 +262,7 @@ pub const MILLIUNIT: Balance = 1_000_000_000;
pub const MICROUNIT: Balance = 1_000_000;

/// The existential deposit. Set to 1/10 of the Connected Relay Chain.
pub const EXISTENTIAL_DEPOSIT: Balance = MILLIUNIT;
pub const EXISTENTIAL_DEPOSIT: Balance = MICROUNIT;

/// We assume that ~5% of the block weight is consumed by `on_initialize` handlers. This is
/// used to limit the maximal weight of a single extrinsic.
Expand Down
Loading