Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Apply new assertions setup #3409

Open
wants to merge 20 commits into
base: dev
Choose a base branch
from
Open

fix: Apply new assertions setup #3409

wants to merge 20 commits into from

Conversation

sfc-gh-asawicki
Copy link
Collaborator

@sfc-gh-asawicki sfc-gh-asawicki commented Feb 21, 2025 •
edited
Loading

Continuation to #3406.

  • Parametrize test client in all assertions and helper functions
  • Alter the generation of object assertions
  • Use proper assertions in all tests
  • Remove deprecated logic
  • Fix assertions in integration tests
  • Split object suffix generation to different packages

@sfc-gh-asawicki
apply new assertions setup starts here
27e18f6
@sfc-gh-asawicki
Modify templates for the snowflake object assertions
c832cb5
@sfc-gh-asawicki
Generate new constructor for each snowflake object assertion
4e2ab56
@sfc-gh-asawicki
Remove the old constructor entirely from template
3451654
@sfc-gh-asawicki
Remove the old constructor from each snowflake assertion object
b84ba6d
@sfc-gh-asawicki
Use the dedicated function
dd80812
@sfc-gh-asawicki
Clean AssertThatObject common function
60ad8df
@sfc-gh-asawicki
Prepare the same logic for parameters check
173c43b
@sfc-gh-asawicki
Generate for all parameters assertions besides account
cfc53c8
@sfc-gh-asawicki
Adjust the account one
c80dba3
@sfc-gh-asawicki
Remove unused ext
39ba2ca
@sfc-gh-asawicki
Adjust assertions in ext
b96bf4d
@sfc-gh-asawicki
Remove deprecated constructors
977d71f
@sfc-gh-asawicki
Clean up the in place verifier interface
5a4a52b
@sfc-gh-asawicki
Handle import asserts
819e1ca
@sfc-gh-asawicki
Handle resource asserts
9d12cc1
@sfc-gh-asawicki
Merge functions
1ae28a6
@sfc-gh-asawicki
Update README
f495541
@sfc-gh-asawicki
Split test objects suffix
4d3dc1d
@sfc-gh-asawicki
Run make pre-push
b10dccf
@sfc-gh-asawicki sfc-gh-asawicki marked this pull request as ready for review February 21, 2025 16:28
@github-actions GitHub Actions
Copy link

Integration tests failure for b10dccf12f6f2a42cd5106e3ae57e82b57e5b5b1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfc-gh-jmichalak sfc-gh-jmichalak Awaiting requested review from sfc-gh-jmichalak

@sfc-gh-jcieslak sfc-gh-jcieslak Awaiting requested review from sfc-gh-jcieslak

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@sfc-gh-asawicki