Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRUD operations for snowflake databases #2

Merged
merged 9 commits into from
Jan 20, 2019
Merged

Conversation

ryanking
Copy link
Contributor

This will CRUD snowflake databases.

Auth is currently username + password only. Will look into okta later.

@ryanking ryanking requested a review from a team as a code owner January 17, 2019 21:35
@codecov
Copy link

codecov bot commented Jan 17, 2019

Codecov Report

Merging #2 into master will decrease coverage by 53.57%.
The diff coverage is 39.18%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master       #2       +/-   ##
===========================================
- Coverage     100%   46.42%   -53.58%     
===========================================
  Files           1        4        +3     
  Lines          21      168      +147     
===========================================
+ Hits           21       78       +57     
- Misses          0       90       +90
Impacted Files Coverage Δ
pkg/snowflake/validation.go 0% <0%> (ø)
pkg/snowflake/escaping.go 100% <100%> (ø)
pkg/resources/database.go 27.38% <27.38%> (ø)
pkg/provider/provider.go 85% <77.5%> (-15%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3a3f03a...aa16dd6. Read the comment docs.

@ryanking ryanking requested a review from a team January 17, 2019 23:15
@ryanking ryanking merged commit 038f761 into master Jan 20, 2019
@ryanking ryanking deleted the ryanking/database branch January 20, 2019 00:12
axis-deputy added a commit to axis-deputy/terraform-provider-snowflake that referenced this pull request Oct 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants