Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump the Arcane.Framework version and fix the Context deserialization #14

Merged
merged 2 commits into from
Oct 2, 2024
Merged

Bump the Arcane.Framework version and fix the Context deserialization #14

merged 2 commits into from
Oct 2, 2024

Conversation

s-vitaliy
Copy link
Contributor

@s-vitaliy s-vitaliy commented Oct 2, 2024 •
edited
Loading

Fixes SneaksAndData/arcane-framework#108

Scope

Implemented:

  • Arcane.Framework version updated
  • Added the ChangeCaptureIntervalSeconds field to the SqlServerStreamContext

Additional changes:

  • Fixed deserialization of the groupingIntervalSeconds CRD field

Checklist

  • GitHub issue exists for this change.
  • Unit tests added and they pass.
  • Line Coverage is at least 80%.
  • Review requested on latest commit.

@s-vitaliy s-vitaliy requested a review from a team as a code owner October 2, 2024 11:08
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 2, 2024

Coverage after merging bump-arcane-framework-version into main will be

0.00%

Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
src
   Program.cs0%0%0%0%17, 21–35, 35, 35–45, 48–50, 52
src/Models
   SqlServerStreamContext.cs0%100%0%0%13, 18, 23, 28, 35, 41, 46, 51, 56, 59, 62, 65, 69–71, 75–77, 81–83, 86–88, 91
src/Services
   SqlServerGraphBuilder.cs0%0%0%0%22–26, 29–30, 32, 34–38, 40–41, 43, 43, 43–50, 52–62, 64–66, 66, 66, 66, 66, 66, 66, 66, 66–69, 72, 72, 72, 72, 72, 72, 72, 72, 72–74, 77, 77, 77–81, 84–85, 87

@s-vitaliy s-vitaliy changed the title Bump the Arcane.Framework version Bump the Arcane.Framework version and fix the Context deserialization Oct 2, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 2, 2024

Coverage after merging bump-arcane-framework-version into main will be

0.00%

Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
src
   Program.cs0%0%0%0%17, 21–35, 35, 35–45, 48–50, 52
src/Models
   SqlServerStreamContext.cs0%100%0%0%13, 18, 23, 28, 35, 41, 46, 51, 56, 59, 62, 65, 69–71, 75–77, 81–83, 86–88, 91
src/Services
   SqlServerGraphBuilder.cs0%0%0%0%22–26, 29–30, 32, 34–38, 40–41, 43, 43, 43–50, 52–62, 64–66, 66, 66, 66, 66, 66, 66, 66, 66–69, 72, 72, 72, 72, 72, 72, 72, 72, 72–74, 77, 77, 77–81, 84–85, 87

@s-vitaliy s-vitaliy merged commit 945c943 into main Oct 2, 2024
2 checks passed
@s-vitaliy s-vitaliy deleted the bump-arcane-framework-version branch October 2, 2024 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adelinag08 adelinag08 adelinag08 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] changeCaptureIntervalSeconds does nothing for SqlServerStream streams
2 participants
@s-vitaliy @adelinag08