Add optional scope normalization

package.json

@@ -1,6 +1,6 @@
 {
   "name": "passport-snapchat",
-  "version": "1.0.0",
+  "version": "1.0.1",
   "description": "Snapchat (OAuth 2.0) authorization strategy for Passport.",
   "keywords": [
     "passport",

src/strategy.ts

@@ -79,6 +79,14 @@ interface SnapchatStrategyOptions {
    * @default ' '
    */
   scopeSeparator?: string;
+  /**
+   * @optional
+   * Determines whether Snapchat's scope strings are normalized according to Snapchat's
+   * convention of prepending the scope URL prefix to the scope string.
+   *
+   * @default true
+   */
+  normalizeScope?: boolean;
   /**
    * @optional
    *
@@ -254,7 +262,7 @@ function getGraphFieldForNormalizedFieldName(field: string): string {
 /**
  * @hidden
  */
-function normalizeScope(scope: string): string {
+function applyScopeNormalization(scope: string): string {
   return scope.startsWith('https:')
     ? scope
     : config.OAUTH_SCOPE_URL_PREFIX + scope;
@@ -273,14 +281,18 @@ function normalizeOptions(
       ? scopesStringOrArray.split(scopeSeparator)
       : scopesStringOrArray;
   const profileFields = options.profileFields || [];
+  const shouldNormalizeScope =
+    options.normalizeScope !== undefined ? options.normalizeScope : true;
   return {
     ...options,
     authorizationURL: options.authorizationURL || config.SNAP_ACCOUNTS_AUTH_URL,
     profileFields: profileFields
       .map(getGraphFieldForNormalizedFieldName)
       .filter(Boolean),
     profileURL: options.profileURL || `${config.SNAP_KIT_API_URL}/me`,
-    scope: scopes.map(normalizeScope).filter(Boolean),
+    scope: shouldNormalizeScope
+      ? scopes.map(applyScopeNormalization).filter(Boolean)
+      : scopes,
     scopeSeparator,
     tokenURL: options.tokenURL || config.SNAP_ACCOUNTS_TOKEN_URL,
   };

test/strategy.spec.ts

@@ -25,7 +25,22 @@ describe('Strategy', function() {
       expect(strategy._scope[0]).to.equal(config.OAUTH_SCOPE_URL_PREFIX + 'user.display_name');
       expect(strategy._scope[1]).to.equal(config.OAUTH_SCOPE_URL_PREFIX + 'user.bitmoji.avatar');
     });
-  })
+  });
+  describe('constructed with normalize scope option set to false', function () {
+    var strategy = new SnapchatStrategy({
+      callbackURL: '',
+      clientID: 'ABC123',
+      clientSecret: 'secret',
+      scope: ['user.display_name', 'user.bitmoji.avatar'],
+      normalizeScope: false
+    },
+      function () { });
+
+    it('should not have fully qualified scopes', function () {
+      expect(strategy._scope[0]).to.equal('user.display_name');
+      expect(strategy._scope[1]).to.equal('user.bitmoji.avatar');
+    });
+  });
 
   describe('constructed with undefined options', function() {
     it('should throw', function() {