Conversation
To fix CI, failing on polling v3.11.0.
PolyMeilex
approved these changes
Jan 6, 2026
Member
PolyMeilex
left a comment
PolyMeilex
left a comment
There was a problem hiding this comment.
Winit 0.30 MSRV is 1.70.0
And Winit master MSRV is 1.85
So I assume we should be fine with 1.71. If I am wrong, and it affects you the reader, feel free to yell at me, and we will revert this in favor of pinning deps manually in the CI like we do in other Smithy projects at times.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To fix CI.
If I'm mistaken about the semantics of MSRV and it actually means "there exists a configuration where this version works", then this should rather be solved by adding Cargo.lock.
If I'm not mistaken and this is a deliberately letting dependencies break CI, then I think the proper fix would move the check to some periodic job, instead of breaking feature pipelines.
But I don't know, so here's the Minimum Viable CI Fix :)