Skip to content

Default Impls for Optional Methods #507

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Default Impls for Optional Methods #507

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f285284
add default impls to CompositorHandler
jenr-dev Nov 16, 2025
ca5f7a7
add default impls to OutputHandler
jenr-dev Nov 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
52 changes: 27 additions & 25 deletions src/compositor.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,20 +25,21 @@ pub trait CompositorHandler: Sized {
/// The surface has either been moved into or out of an output and the output has a different scale factor.
fn scale_factor_changed(
&mut self,
conn: &Connection,
qh: &QueueHandle<Self>,
surface: &wl_surface::WlSurface,
new_factor: i32,
);
_conn: &Connection,
_qh: &QueueHandle<Self>,
_surface: &wl_surface::WlSurface,
_new_factor: i32,
) { /* No-op default impl */ }

/// The surface has either been moved into or out of an output and the output has different transform.
fn transform_changed(
&mut self,
conn: &Connection,
qh: &QueueHandle<Self>,
surface: &wl_surface::WlSurface,
new_transform: wl_output::Transform,
);
_conn: &Connection,
_qh: &QueueHandle<Self>,
_surface: &wl_surface::WlSurface,
_new_transform: wl_output::Transform,
) { /* No-op default impl */ }


/// A frame callback has been completed.
///
Expand All @@ -52,29 +53,30 @@ pub trait CompositorHandler: Sized {
/// for other values to more easily dispatch rendering for specific surface types.
fn frame(
&mut self,
conn: &Connection,
qh: &QueueHandle<Self>,
surface: &wl_surface::WlSurface,
time: u32,
);
_conn: &Connection,
_qh: &QueueHandle<Self>,
_surface: &wl_surface::WlSurface,
_time: u32,
) { /* No-op default impl */ }


/// The surface has entered an output.
fn surface_enter(
&mut self,
conn: &Connection,
qh: &QueueHandle<Self>,
surface: &wl_surface::WlSurface,
output: &wl_output::WlOutput,
);
_conn: &Connection,
_qh: &QueueHandle<Self>,
_surface: &wl_surface::WlSurface,
_output: &wl_output::WlOutput,
) { /* No-op default impl */ }

/// The surface has left an output.
fn surface_leave(
&mut self,
conn: &Connection,
qh: &QueueHandle<Self>,
surface: &wl_surface::WlSurface,
output: &wl_output::WlOutput,
);
_conn: &Connection,
_qh: &QueueHandle<Self>,
_surface: &wl_surface::WlSurface,
_output: &wl_output::WlOutput,
) { /* No-op default impl */ }
}

pub trait SurfaceDataExt: Send + Sync {
Expand Down
24 changes: 12 additions & 12 deletions src/output.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,28 +28,28 @@ pub trait OutputHandler: Sized {
/// A new output has been advertised.
fn new_output(
&mut self,
conn: &Connection,
qh: &QueueHandle<Self>,
output: wl_output::WlOutput,
);
_conn: &Connection,
_qh: &QueueHandle<Self>,
_output: wl_output::WlOutput,
) { /* No-op default impl */ }

/// An existing output has changed.
fn update_output(
&mut self,
conn: &Connection,
qh: &QueueHandle<Self>,
output: wl_output::WlOutput,
);
_conn: &Connection,
_qh: &QueueHandle<Self>,
_output: wl_output::WlOutput,
) { /* No-op default impl */ }

/// An output is no longer advertised.
///
/// The info passed to this function was the state of the output before destruction.
fn output_destroyed(
&mut self,
conn: &Connection,
qh: &QueueHandle<Self>,
output: wl_output::WlOutput,
);
_conn: &Connection,
_qh: &QueueHandle<Self>,
_output: wl_output::WlOutput,
) { /* No-op default impl */ }
}

type ScaleWatcherFn =
Expand Down