Enable strict mode by default #191
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guvra
force-pushed
the
feat-strict-mode-enabled
branch
2 times, most recently
from
d492ea9 to
48e9e66
Compare
guvra
force-pushed
the
feat-strict-mode-enabled
branch
7 times, most recently
from
4d36b4e to
7c7af11
Compare
guvra
force-pushed
the
feat-strict-mode-enabled
branch
from
7c7af11 to
611925d
Compare
guvra
force-pushed
the
feat-strict-mode-enabled
branch
from
611925d to
31d8b8f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables the
strict_schemaoption by default (except in config templates, e.g.magento2).This is a breaking change.
When this mode is enabled, the dump creation fails if the configuration file contains undefined table names.
An error is also triggered if a pattern (e.g.
log_*) does not match any existing table.The default is still
falsein config templates because depending on the framework version and edition, some tables may or may not exist.