Merged
Conversation
Merge branch 'develop' of https://github.com/SmashStudy/ESquad-BE into feature/43
kimmin1kk
reviewed
Oct 31, 2024
| public ResponseEntity<SseEmitter> subscribe(@Parameter(hidden = true)Principal principal, | ||
| public ResponseEntity<SseEmitter> subscribe(@Parameter(hidden = true) Principal principal, | ||
| @RequestHeader(value = "Last-Event-ID", required = false, defaultValue = "") String lastEventId) { | ||
| log.info("user, lastEventId: {}, {}", principal.getName(), lastEventId); |
| public ResponseEntity<List<TeamSpaceUserResponseDTO>> getCrewProfile(@PathVariable("id") Long teamId, Principal principal) { | ||
| teamSpaceUserService.checkRole(teamId, principal.getName()); | ||
| return ResponseEntity.status(HttpStatus.OK).body(teamService.getCrewProfile(teamId)); | ||
| log.info(principal.toString()); |
| @NotBlank UserResponseDTO member, | ||
| // @NotBlank TeamSpaceRequestDTO teamSpace, | ||
| @NotBlank UserRequestDTO member, | ||
| // @NotBlank LocalDateTime createdAt, |
Contributor
There was a problem hiding this comment.
무의미한 주석이 남아있는 것 같아요! 확인부탁드립니다!
| public record TeamSpaceUserResponseDTO( // 팀스페이스 멤버정보 | ||
| public record TeamSpaceUserResponseDTO( | ||
| @NotNull Long id, | ||
| // @ToString.Exclude |
|
|
||
| import java.util.Optional; | ||
|
|
||
| @Slf4j |
Contributor
There was a problem hiding this comment.
사용되지 않고 있는 거 같아서 없애도 될 거 같아요!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#43