Merged
Conversation
…into feature/36
UNPROCESSABLE_ENTITY -> UNAUTHORIZED
kimmin1kk
reviewed
Oct 25, 2024
Contributor
kimmin1kk
left a comment
kimmin1kk
left a comment
There was a problem hiding this comment.
확인했습니다! 리뷰 확인해주시면 감사하겠습니당
src/test/java/com/esquad/esquadbe/studypage/service/StudyPageCreateServiceTest.java
Outdated
Show resolved
Hide resolved
kimmin1kk
reviewed
Oct 30, 2024
Comment on lines
52
to
54
| } catch (Exception e) { | ||
| return ResponseEntity.status(HttpStatus.INTERNAL_SERVER_ERROR).body(null); | ||
| } |
Contributor
There was a problem hiding this comment.
이 부분은 Exception e catch 해서 처리하신 이유가 따로 있으신건가요?!
Comment on lines
16
to
17
| // (HttpStatus.,"","STUDYPAGE-0011"), | ||
| // (HttpStatus.,"","STUDYPAGE-0012-"), |
Contributor
There was a problem hiding this comment.
이 주석은 사용되지 않을 것 같은데 지워주셔도 좋을 것 같아요!
Comment on lines
42
to
44
| log.info("try"); | ||
| try { | ||
| log.info("Creating a new study page for teamId: {}", teamId); |
Contributor
There was a problem hiding this comment.
merge 하기 전에 log 부분 날려주세요!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.