Skip to content

RFC4912 required a <type> for a named type that defines a type #365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 13, 2020

Conversation

SmartLayer
Copy link

  1. merge this together with RFC4912 required a <type> for a named type that defines a type TokenScript-Examples#93

  2. Don't merge this in until both αW can handle the new schema.

@hboon
Copy link
Member

hboon commented Jun 25, 2020

@colourful-land should this require a new schema version since 2020/06 has already been shipped?

@SmartLayer SmartLayer force-pushed the correct-violation-of-rfc4912 branch from a75c2ee to c506dc1 Compare June 25, 2020 07:42
@SmartLayer
Copy link
Author

SmartLayer commented Jun 25, 2020

@colourful-land should this require a new schema version since 2020/06 has already been shipped?

I was hoping to sneak that in since we can't do a new schema version until 2021. The αW can be written to handle both cases (<type> clearly defined or missing out). If you use xpath it should be easy to include the case with <type> or not

@hboon
Copy link
Member

hboon commented Jun 25, 2020

@colourful-land should this require a new schema version since 2020/06 has already been shipped?

I was hoping to sneak that in since we can't do a new schema version until 2021. The αW can be written to handle both cases (<type> clearly defined or missing out). If you use xpath it should be easy to include the case with <type> or not

We can do that in an updated app version. But the older versions in the install base will pick up the updated TokenScript files that includes this change like this [1] and break.

[1] https://github.com/AlphaWallet/TokenScript-Examples/pull/93/files

@SmartLayer
Copy link
Author

@hboon exactly. How about we make αW android/ios both compatible with both format and wait a few weeks to see how many users upgraded before updating the Repo server?

@hboon
Copy link
Member

hboon commented Jun 26, 2020

@colourful-land I don't mind either way. You and @James-Sangalli decide then :)

@SmartLayer SmartLayer mentioned this pull request Jul 5, 2020
1 task
@SmartLayer
Copy link
Author

SmartLayer commented Jul 9, 2020

2\. Don't merge this in until both αW can handle the new schema.

We are getting there. It's been 3 days and the 3.0.5 user base has just surpassed the 3.0.2 user base. I hope by the end of this week we can merge this in already.

@SmartLayer SmartLayer merged commit d076ff6 into master Jul 13, 2020
@JamesANZ JamesANZ deleted the correct-violation-of-rfc4912 branch July 13, 2020 00:19
@SmartLayer
Copy link
Author

Usage of the Android version that didn't support <type> dropped to 15% (iOS should have fallen below this many days ago), so merging this in. I used merge instead of squash because this branch has a fork that is in PR to be merged soon

SmartLayer pushed a commit that referenced this pull request Jun 30, 2023
RFC4912 required a <type> for a named type that defines a type
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants