-
Notifications
You must be signed in to change notification settings - Fork 69
RFC4912 required a <type> for a named type that defines a type #365
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@colourful-land should this require a new schema version since |
a75c2ee
to
c506dc1
Compare
I was hoping to sneak that in since we can't do a new schema version until 2021. The αW can be written to handle both cases ( |
We can do that in an updated app version. But the older versions in the install base will pick up the updated TokenScript files that includes this change like this [1] and break. [1] https://github.com/AlphaWallet/TokenScript-Examples/pull/93/files |
@hboon exactly. How about we make αW android/ios both compatible with both format and wait a few weeks to see how many users upgraded before updating the Repo server? |
@colourful-land I don't mind either way. You and @James-Sangalli decide then :) |
We are getting there. It's been 3 days and the 3.0.5 user base has just surpassed the 3.0.2 user base. I hope by the end of this week we can merge this in already. |
Usage of the Android version that didn't support |
RFC4912 required a <type> for a named type that defines a type
merge this together with RFC4912 required a <type> for a named type that defines a type TokenScript-Examples#93
Don't merge this in until both αW can handle the new schema.