Skip to content

Approved to move and Gave approval to move activities title are truncated #389

Description

@hboon

These 2 activities seem to frequently be associated with a large value that the following text is often (always?) truncated:

Approved to move <symbol>

and:

Gave approval to move <symbol>

Maybe truncate middle or hide the value completely for these 2 activities?

Activity

  1. overseers-desk commented on Sep 20, 2020

    @overseers-desk

    I checked MetaMask and in their Activity, they simply hid the amount that is approved.

    screenshot

    Is it urgent? The reason I ask is that it seems all dapps today approved a maximum possible number (transaction generated by Uniswap). So I may update the code to show "Unlimited" instead. That requires a bit of JS detective work.

    screenshot

  2. hboon commented on Sep 21, 2020

    @hboon
    MemberAuthor

    Not urgent

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

No labels
No labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions