Skip to content

fix: Async issues with handleHttpCallbackUnverified #254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

AmineI
Copy link

@AmineI AmineI commented Dec 26, 2023

Hello,

Issues arise with testing SmartApp locally, due to handleHttpCallbackUnverified not being an async method.

As with other methods, and following the documentation, handleHttpCallbackUnverified now returns a Promise and can be properly awaited.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • I have read the CONTRIBUTING document
  • My code follows the code style of this project (hint: install an xo editor plugin)
  • Any required documentation has been added
  • I have added tests to cover my changes

@AmineI
Copy link
Author

AmineI commented Jan 2, 2024

Amended commit name to fix the commit-lint failed step 🙂.

@AmineI
Copy link
Author

AmineI commented Jan 12, 2024

These changes were included as part of #259 . Thanks & well done !
I'll close this PR - A comment or heads-up here would have been appreciated, however :).

Have a great week-end !

@AmineI AmineI closed this Jan 12, 2024
@AmineI AmineI deleted the patch-1 branch January 12, 2024 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants