Skip to content

Conversation

@hcarter-775
Copy link
Contributor

@hcarter-775 hcarter-775 commented Nov 3, 2025

Description of Change

Similar to the updates to Matter Switch: #2401

This re-organizes the Matter Sensor driver to be more easily understandable and developer friendly.

I also updated the copyrights to the new shortened versions.

Summary of Completed Tests

Tested VDA Device Types:

  • Humidity Sensor
  • Temperature Sensor
  • Contact Sensor
  • Light Sensor
  • Leak Detector
  • Water Freeze Detector
  • Air Quality Sensor (uses modular profile path)
  • Smoke CO Alarm

I also spot checked the new paths in the way I described in the linked PR description. I will omit that here since I go into detail there.

Unit tests worked as expected given the current test framework for lower lua libs, ensuring the embedded cluster require changes work as expected.

@github-actions
Copy link

github-actions bot commented Nov 3, 2025

Channel deleted.

@github-actions
Copy link

github-actions bot commented Nov 3, 2025

Test Results

   71 files    464 suites   0s ⏱️
2 411 tests 2 411 ✅ 0 💤 0 ❌
4 094 runs  4 094 ✅ 0 💤 0 ❌

Results for commit a04cce4.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Nov 3, 2025

File Coverage
All files 86%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-sensor/src/sensor_utils/device_configuration.lua 89%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-sensor/src/sensor_utils/embedded_cluster_utils.lua 45%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-sensor/src/sub_drivers/bosch_button_contact/init.lua 85%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-sensor/src/sub_drivers/smoke_co_alarm/init.lua 83%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-sensor/src/sub_drivers/air_quality_sensor/init.lua 80%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-sensor/src/sub_drivers/air_quality_sensor/device_configuration.lua 90%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-sensor/src/sub_drivers/air_quality_sensor/fields.lua 92%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-sensor/src/sub_drivers/air_quality_sensor/legacy_device_configuration.lua 92%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-sensor/src/init.lua 92%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-sensor/src/sensor_handlers/attribute_handlers.lua 88%

Minimum allowed coverage is 90%

Generated by 🐒 cobertura-action against a04cce4

@hcarter-775 hcarter-775 changed the title Matter Sensor: Re-organize the file organization Matter Sensor: Re-organize the directory structure Nov 3, 2025
Copy link
Contributor

@greens greens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could change the copyright here as well, while you're at it.

(and you have a conflict)

@hcarter-775 hcarter-775 force-pushed the reorder/matter-sensor branch from 16d86b4 to 0b11761 Compare November 4, 2025 23:35
@hcarter-775
Copy link
Contributor Author

@greens great minds think alike- I actually did change the copyright for all these

@hcarter-775 hcarter-775 force-pushed the reorder/matter-sensor branch from bf4389d to a04cce4 Compare November 5, 2025 19:45
@hcarter-775 hcarter-775 merged commit 737773e into main Nov 10, 2025
11 checks passed
@hcarter-775 hcarter-775 deleted the reorder/matter-sensor branch November 10, 2025 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants