Skip to content

Modular Profiles: Gate HubCore 0.57 Release Required Logic #2350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 25, 2025
Merged

Modular Profiles: Gate HubCore 0.57 Release Required Logic #2350

merged 1 commit into from
Sep 25, 2025

Conversation

@hcarter-775
Copy link
Contributor

@hcarter-775 hcarter-775 commented Aug 18, 2025 •
edited
Loading

Check all that apply

Type of Change

  • WWST Certification Request
    • If this is your first time contributing code:
      • I have reviewed the README.md file
      • I have reviewed the CODE_OF_CONDUCT.md file
      • I have signed the CLA
    • I plan on entering a WWST Certification Request or have entered a request through the WWST Certification console at developer.smartthings.com
  • Bug fix
  • New feature
  • Refactor

Checklist

  • I have performed a self-review of my code
  • I have commented my code in hard-to-understand areas
  • I have verified my changes by testing with a device or have communicated a plan for testing
  • I am adding new behavior, such as adding a sub-driver, and have added and run new unit tests to cover the new behavior

Description of Change

Gate pre-0.58 logic for modular profiling. It is confirmed that these versions have been bumped in 0.58.

Summary of Completed Tests

Test Devices Used: VDA versions of all affected device types (Air Quality Sensor, Air Purifier, Thermostat, and Room Air Conditioner)

Tests Completed:

  1. For each of the above device types, when run on the 0.58.x Hub firmware it was confirmed through logs that the proper subscriptions were handled for each device's particular capability-attribute mapping. Further, extra debug logic was included to ensure the proper profile was directly being serialized into lua.
  2. Testing with the AP and AQS VDA, when run on the released 0.57 Hub firmware, it was confirmed through subscription logs that when moving from the previous production driver to this change, the correct subscription continues to hold.
  3. Testing with the AP and AQS VDA. when run on the 0.58 Hub firmware, it was confirmed through subscription logs that when moving from the previous production driver to this change, the correct subscription continues to hold.

@github-actions
Copy link

github-actions bot commented Aug 18, 2025 •
edited
Loading

Channel deleted.

@github-actions
Copy link

github-actions bot commented Aug 18, 2025 •
edited
Loading

Test Results

   71 files    452 suites   0s ⏱️
2 351 tests 2 351 ✅ 0 💤 0 ❌
3 959 runs  3 959 ✅ 0 💤 0 ❌

Results for commit e407458.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Aug 18, 2025 •
edited
Loading

matter-sensor_coverage.xml

File Coverage
All files 87% ❌
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-sensor/src/bosch-button-contact/init.lua 85% ❌
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-sensor/src/air-quality-sensor/init.lua 90% ✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-sensor/src/init.lua 91% ✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-sensor/src/embedded-cluster-utils.lua 45% ❌
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-sensor/src/smoke-co-alarm/init.lua 85% ❌

matter-thermostat_coverage.xml

File Coverage
All files 91% ✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-sensor/src/bosch-button-contact/init.lua 85% ❌
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-sensor/src/air-quality-sensor/init.lua 90% ✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-sensor/src/init.lua 91% ✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-sensor/src/embedded-cluster-utils.lua 45% ❌
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-sensor/src/smoke-co-alarm/init.lua 85% ❌
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-thermostat/src/embedded-cluster-utils.lua 95% ✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-thermostat/src/init.lua 90% ✅

Minimum allowed coverage is 90%

Generated by 🐒 cobertura-action against e407458

ctowns
ctowns reviewed Aug 18, 2025
View reviewed changes
drivers/SmartThings/matter-sensor/src/air-quality-sensor/init.lua Outdated
table.insert(total_supported_capabilities[MAIN_COMPONENT_IDX][CAPABILITIES_LIST_IDX], capabilities.firmwareUpdate.ID)

device:set_field(SUPPORTED_COMPONENT_CAPABILITIES, total_supported_capabilities, { persist = true })
if version.api < 15 and version.rpc < 9 then
Copy link
Contributor

@ctowns ctowns Aug 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a brief comment indicating why this is needed and why we can't just rely on the the check for FW57 that is is done before calling into this function? Also could you create a ticket to eventually remove the old workaround entirely?

Copy link
Contributor Author

@hcarter-775 hcarter-775 Aug 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done and done

ctowns
ctowns reviewed Aug 18, 2025
View reviewed changes
Copy link
Contributor

@ctowns ctowns left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you provide more detail in the "Summary of Completed Testing" section? One good test would be to do an A/B comparison between the subscription request that is sent out for a modular device with this change and without this change to confirm they are the same.

Also, could you test with a device that is onboarded to the existing production driver, then updates to this driver and confirm that the device sends out the correct subscription upon driver restart? It would be good to smoke test this case on 57 vs 58 FW versions.

@hcarter-775 hcarter-775 force-pushed the update-modular-profile-logic branch from 89618f1 to e407458 Compare September 25, 2025 18:22
@hcarter-775 hcarter-775 merged commit 697c1d0 into main Sep 25, 2025
12 checks passed
@hcarter-775 hcarter-775 deleted the update-modular-profile-logic branch September 25, 2025 18:34
@hcarter-775 hcarter-775 changed the title Modular Profiles: Gate HubCore 0.58 Release Required Logic Modular Profiles: Gate HubCore 0.57 Release Required Logic Oct 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ctowns ctowns ctowns approved these changes

@nickolas-deboom nickolas-deboom nickolas-deboom approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@hcarter-775 @ctowns @nickolas-deboom