Skip to content

Update judgement to use modular profile for thermostat #2237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Update judgement to use modular profile for thermostat #2237

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bbee5a3
Update judgement to use modular profile for thermostat
Huangxiangjie Jul 7, 2025
96c2001
Update unit test
Huangxiangjie Jul 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion drivers/SmartThings/matter-thermostat/src/init.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1114,7 +1114,7 @@ local function supports_modular_profile(device)
return version.api >= 14 and version.rpc >= 8 and
(device_type == AP_DEVICE_TYPE_ID or
device_type == RAC_DEVICE_TYPE_ID or
(device_type == false and #thermostat_eps > 0))
device_type == THERMOSTAT_DEVICE_TYPE_ID)
end

function match_profile(driver, device)
Expand Down
3 changes: 3 additions & 0 deletions drivers/SmartThings/matter-thermostat/src/test/test_matter_thermostat_modular.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,9 @@ local mock_device_basic = test.mock_device.build_test_matter_device({
{cluster_id = clusters.TemperatureMeasurement.ID, cluster_type = "SERVER"},
{cluster_id = clusters.RelativeHumidityMeasurement.ID, cluster_type = "SERVER"},
{cluster_id = clusters.PowerSource.ID, cluster_type = "SERVER"},
},
device_types = {
{device_type_id = 0x0301, device_type_revision = 1} -- Thermostat
}
}
}
Expand Down
Loading