Matter Switch: Add greater Energy profiling logic for Switches #2199
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Duplicate profile check: Passed - no duplicate profiles detected. |
|
Invitation URL: |
Test Results 67 files 441 suites 0s ⏱️ Results for commit ca5b1d0. ♻️ This comment has been updated with latest results. |
|
Minimum allowed coverage is Generated by 🐒 cobertura-action against ca5b1d0 |
…hingsCommunity/SmartThingsEdgeDrivers into add/power-topology-handling
drivers/SmartThings/matter-switch/src/test/test_aqara_light_switch_h2.lua
Outdated
Show resolved
Hide resolved
|
These changes look great! I think it might be a good idea to test on some additional device types since some of the init code is being changed. |
hcarter-775
force-pushed
the
add/power-topology-handling
branch
from
aeafdff to
ca5b1d0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Update the Matter Switch driver to support the Power Topology cluster. Specifically, include support for the Node and Set features of the cluster. Update unit tests to handle this update.
Further, update
powerConsumptionReporthandling to only send reports to one single capability, even when there are multiple child devices getting energy reports.Last, update energy and power handlers from emit_event_for_endpoint() calls to emit_component_event() calls to simplify handling by avoiding the weaknesses in our current
endpoint_to_component()functionality.Summary of Completed Tests
Tests updated and continue to pass.
Tested on multi-plug energy device.
Tested on single plug energy device.