Skip to content

Modular profiles for matter switch #2112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 14 commits into from
Closed

Modular profiles for matter switch #2112

wants to merge 14 commits into from

Conversation

nickolas-deboom
Copy link
Contributor

@nickolas-deboom nickolas-deboom commented May 6, 2025 •
edited
Loading

Type of Change

  • WWST Certification Request
    • If this is your first time contributing code:
      • I have reviewed the README.md file
      • I have reviewed the CODE_OF_CONDUCT.md file
      • I have signed the CLA
    • I plan on entering a WWST Certification Request or have entered a request through the WWST Certification console at developer.smartthings.com
  • Bug fix
  • New feature
  • Refactor

Checklist

  • I have performed a self-review of my code
  • I have commented my code in hard-to-understand areas
  • I have verified my changes by testing with a device or have communicated a plan for testing
  • I am adding new behavior, such as adding a sub-driver, and have added and run new unit tests to cover the new behavior

Description of Change

Adding support for modular profiles for the matter switch driver.

Summary of Completed Tests

@github-actions GitHub Actions
Copy link

github-actions bot commented May 6, 2025

Duplicate profile check: Passed - no duplicate profiles detected.

@github-actions GitHub Actions
Copy link

github-actions bot commented May 6, 2025 •
edited
Loading

Channel deleted.

@github-actions GitHub Actions
Copy link

github-actions bot commented May 6, 2025 •
edited
Loading

Test Results

   67 files    441 suites   0s ⏱️
2 251 tests 2 251 ✅ 0 💤 0 ❌
3 843 runs  3 843 ✅ 0 💤 0 ❌

Results for commit 91a5f9e.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented May 6, 2025 •
edited
Loading

File Coverage
All files 88% ❌
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-switch/src/third-reality-mk1/init.lua 95% ✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-switch/src/aqara-cube/init.lua 96% ✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-switch/src/init.lua 87% ❌
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-switch/src/eve-energy/init.lua 92% ✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-switch/src/embedded-cluster-utils.lua 38% ❌

Minimum allowed coverage is 90%

Generated by 🐒 cobertura-action against 91a5f9e

@nickolas-deboom nickolas-deboom force-pushed the matter-switch-update-field-names branch from 3d2d422 to 49ba419 Compare May 9, 2025 16:10
@nickolas-deboom nickolas-deboom force-pushed the modular-profiles-test-matter-switch branch from 5eb9086 to f62162d Compare May 9, 2025 18:36
@nickolas-deboom nickolas-deboom force-pushed the matter-switch-update-field-names branch from 49ba419 to ea07e1b Compare May 9, 2025 18:37
@nickolas-deboom nickolas-deboom force-pushed the modular-profiles-test-matter-switch branch 3 times, most recently from 1edd282 to 86c5572 Compare May 9, 2025 18:43
@nickolas-deboom nickolas-deboom force-pushed the matter-switch-update-field-names branch from ea07e1b to 653030b Compare May 9, 2025 18:47
@nickolas-deboom nickolas-deboom force-pushed the modular-profiles-test-matter-switch branch from 86c5572 to 0895ef7 Compare May 9, 2025 18:53
hcarter-775
hcarter-775 reviewed May 12, 2025
View reviewed changes
drivers/SmartThings/matter-switch/profiles/switch-modular.yml
optional: true
- id: batteryLevel
optional: true
categories:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since these categories aren't actually being used, I kinda lean against adding them. What do you think?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could go either way on that, since we use categories for secondary components in existing profiles. I think the plugin might actually use the category for things too, but I'm not certain

@nickolas-deboom nickolas-deboom force-pushed the matter-switch-update-field-names branch from 653030b to ea1236c Compare May 13, 2025 15:40
Base automatically changed from matter-switch-update-field-names to main May 13, 2025 15:48
@nickolas-deboom nickolas-deboom force-pushed the modular-profiles-test-matter-switch branch 6 times, most recently from a7b3ff4 to f3eb6b5 Compare May 15, 2025 16:39
@nickolas-deboom nickolas-deboom changed the title Modular profiles test for matter switch Modular profiles for matter switch May 15, 2025
@nickolas-deboom nickolas-deboom force-pushed the modular-profiles-test-matter-switch branch 2 times, most recently from b6a1580 to 2da14cc Compare May 15, 2025 21:33
@nickolas-deboom nickolas-deboom force-pushed the modular-profiles-test-matter-switch branch 2 times, most recently from 83f6ba7 to aab9ad4 Compare May 16, 2025 00:59
@nickolas-deboom
Modular profiles test for matter switch
f012b8c
@nickolas-deboom
Adding support for more clusters and device types
e7c659b
@nickolas-deboom
Fix color control endpoint handling
4525d80
@nickolas-deboom
Fix color ep handling
8441ec1
@nickolas-deboom
Make capabilities optional in profile
aab65f9
@nickolas-deboom
Improve match_modular_profile function
07ea8c6 
With the previous commit, switches and buttons were not being initialized when modular
profiles were used
@nickolas-deboom
Add switchLevel in case of on off color dimmer switch
5d9753a
@nickolas-deboom
Add initial test cases and improve match_modular_profile logic
198e42b
@nickolas-deboom
Fix default endpoint logic for button/switch devices
6b06f7a
@nickolas-deboom
Add new test cases
9ed4c83
@nickolas-deboom
Support more device types
f3968e5 
Add new modular profiles to support other device types that require different
categories. Add new logic in the driver to support the new profiles.
@nickolas-deboom
minor fixes
f4e3cd8
@nickolas-deboom
Fix bug for Light Switch device types
7123dd0
@nickolas-deboom nickolas-deboom force-pushed the modular-profiles-test-matter-switch branch 2 times, most recently from 4b4d5a4 to fb3e7d3 Compare May 22, 2025 20:11
@nickolas-deboom
Add handling for additional plug components
91a5f9e 
Support additional, optional plug components in the plug-modular
profile. Also, fix the component mapping for button endpoints.
@nickolas-deboom nickolas-deboom force-pushed the modular-profiles-test-matter-switch branch from fb3e7d3 to 91a5f9e Compare May 22, 2025 21:14
@nickolas-deboom nickolas-deboom mentioned this pull request May 28, 2025
Open
12 tasks
@nickolas-deboom
Copy link
Contributor Author

I will likely be closing this PR, please see latest changes from #2142

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hcarter-775 hcarter-775 hcarter-775 left review comments

@ctowns ctowns Awaiting requested review from ctowns

@z-michel z-michel Awaiting requested review from z-michel

Assignees
No one assigned
Labels
do not merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nickolas-deboom @hcarter-775